chrome/common/extensions/manifest_handlers/automation.h - Issue 2141753002: [Extensions] Code cleanup - const &s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_handlers/automation.h

Issue 2141753002: [Extensions] Code cleanup - const &s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/manifest_handlers/automation.h

diff --git a/chrome/common/extensions/manifest_handlers/automation.h b/chrome/common/extensions/manifest_handlers/automation.h

index afbaee16e75bf33aeb50f94bf74736247ed16e61..eb1c1dcf17bdf0d1cb8fdb94ca503275a34a0949 100644

--- a/chrome/common/extensions/manifest_handlers/automation.h

+++ b/chrome/common/extensions/manifest_handlers/automation.h

@@ -59,7 +59,7 @@ struct AutomationInfo : public Extension::ManifestData {

private:

AutomationInfo();

- AutomationInfo(bool desktop, URLPatternSet matches, bool interact);

+ AutomationInfo(bool desktop, const URLPatternSet& matches, bool interact);

static std::unique_ptr<api::manifest_types::Automation> AsManifestType(

const AutomationInfo& info);