Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2140533003: DevTools: rename initialUrl to url in the Browser.createTarget protocol method. (Closed)

Created:
4 years, 5 months ago by pfeldman
Modified:
4 years, 5 months ago
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, darin-cc_chromium.org, devtools-reviews_chromium.org, jam, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: rename initialUrl to url in the Browser.createTarget protocol method, fix chrome embedder handler. Committed: https://crrev.com/bfec2ff09dfb320ca7786402a804571a4baae37b Cr-Commit-Position: refs/heads/master@{#404886}

Patch Set 1 #

Patch Set 2 : lcean #

Patch Set 3 : test fixed #

Patch Set 4 : headless test fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M components/devtools_discovery/devtools_discovery_manager.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/devtools/protocol/browser_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/protocol/browser_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_browsertest.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M headless/lib/headless_devtools_client_browsertest.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 49 (29 generated)
pfeldman
4 years, 5 months ago (2016-07-11 23:13:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140533003/1
4 years, 5 months ago (2016-07-11 23:14:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140533003/20001
4 years, 5 months ago (2016-07-11 23:28:17 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/188965)
4 years, 5 months ago (2016-07-11 23:58:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140533003/40001
4 years, 5 months ago (2016-07-12 01:46:47 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/242204)
4 years, 5 months ago (2016-07-12 03:33:00 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140533003/40001
4 years, 5 months ago (2016-07-12 03:40:07 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/242268)
4 years, 5 months ago (2016-07-12 05:00:55 UTC) #20
alex clarke (OOO till 29th)
lgtm
4 years, 5 months ago (2016-07-12 12:33:06 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140533003/40001
4 years, 5 months ago (2016-07-12 21:25:07 UTC) #24
paulirish
lgtm
4 years, 5 months ago (2016-07-12 21:27:34 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140533003/40001
4 years, 5 months ago (2016-07-12 21:42:50 UTC) #29
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-12 21:45:17 UTC) #31
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 21:45:57 UTC) #32
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/d3814a729f29e99cbdcbd470d2520cacb5ec4e53 Cr-Commit-Position: refs/heads/master@{#404839}
4 years, 5 months ago (2016-07-12 21:47:47 UTC) #34
pfeldman
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2143183003/ by pfeldman@chromium.org. ...
4 years, 5 months ago (2016-07-12 22:10:33 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140533003/60001
4 years, 5 months ago (2016-07-12 22:26:03 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140533003/60001
4 years, 5 months ago (2016-07-12 23:51:01 UTC) #46
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-13 01:49:40 UTC) #47
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 01:51:20 UTC) #49
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/bfec2ff09dfb320ca7786402a804571a4baae37b
Cr-Commit-Position: refs/heads/master@{#404886}

Powered by Google App Engine
This is Rietveld 408576698