|
|
Chromium Code Reviews|
Created:
4 years, 5 months ago by pfeldman Modified:
4 years, 5 months ago CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, darin-cc_chromium.org, devtools-reviews_chromium.org, jam, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: rename initialUrl to url in the Browser.createTarget protocol method, fix chrome embedder handler.
Committed: https://crrev.com/bfec2ff09dfb320ca7786402a804571a4baae37b
Cr-Commit-Position: refs/heads/master@{#404886}
Patch Set 1 #Patch Set 2 : lcean #Patch Set 3 : test fixed #Patch Set 4 : headless test fixed #
Messages
Total messages: 49 (29 generated)
pfeldman@chromium.org changed reviewers: + paulirish@chromium.org
Description was changed from ========== DevTools: rename initialUrl to url in the Browser.createTarget protocol method. ========== to ========== DevTools: rename initialUrl to url in the Browser.createTarget protocol method. TBR=paulirish ==========
The CQ bit was checked by pfeldman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by pfeldman@chromium.org
Description was changed from ========== DevTools: rename initialUrl to url in the Browser.createTarget protocol method. TBR=paulirish ========== to ========== DevTools: rename initialUrl to url in the Browser.createTarget protocol method, fix chrome embedder handler. TBR=alexclarke ==========
pfeldman@chromium.org changed reviewers: + alexclarke@chromium.org
The CQ bit was checked by pfeldman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by pfeldman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by pfeldman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
lgtm
Description was changed from ========== DevTools: rename initialUrl to url in the Browser.createTarget protocol method, fix chrome embedder handler. TBR=alexclarke ========== to ========== DevTools: rename initialUrl to url in the Browser.createTarget protocol method, fix chrome embedder handler. TBR=alexclarke NOTRY=true ==========
The CQ bit was checked by pfeldman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by pfeldman@chromium.org
Description was changed from ========== DevTools: rename initialUrl to url in the Browser.createTarget protocol method, fix chrome embedder handler. TBR=alexclarke NOTRY=true ========== to ========== DevTools: rename initialUrl to url in the Browser.createTarget protocol method, fix chrome embedder handler. TBR=alexclarke NOTRY=true NOPRESUBMIT=true ==========
The CQ bit was checked by pfeldman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== DevTools: rename initialUrl to url in the Browser.createTarget protocol method, fix chrome embedder handler. TBR=alexclarke NOTRY=true NOPRESUBMIT=true ========== to ========== DevTools: rename initialUrl to url in the Browser.createTarget protocol method, fix chrome embedder handler. TBR=alexclarke NOTRY=true NOPRESUBMIT=true ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== DevTools: rename initialUrl to url in the Browser.createTarget protocol method, fix chrome embedder handler. TBR=alexclarke NOTRY=true NOPRESUBMIT=true ========== to ========== DevTools: rename initialUrl to url in the Browser.createTarget protocol method, fix chrome embedder handler. TBR=alexclarke NOTRY=true NOPRESUBMIT=true Committed: https://crrev.com/d3814a729f29e99cbdcbd470d2520cacb5ec4e53 Cr-Commit-Position: refs/heads/master@{#404839} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/d3814a729f29e99cbdcbd470d2520cacb5ec4e53 Cr-Commit-Position: refs/heads/master@{#404839}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2143183003/ by pfeldman@chromium.org. The reason for reverting is: Broke a test..
Message was sent while issue was closed.
Description was changed from ========== DevTools: rename initialUrl to url in the Browser.createTarget protocol method, fix chrome embedder handler. TBR=alexclarke NOTRY=true NOPRESUBMIT=true Committed: https://crrev.com/d3814a729f29e99cbdcbd470d2520cacb5ec4e53 Cr-Commit-Position: refs/heads/master@{#404839} ========== to ========== DevTools: rename initialUrl to url in the Browser.createTarget protocol method, fix chrome embedder handler. TBR=alexclarke ==========
Description was changed from ========== DevTools: rename initialUrl to url in the Browser.createTarget protocol method, fix chrome embedder handler. TBR=alexclarke ========== to ========== DevTools: rename initialUrl to url in the Browser.createTarget protocol method, fix chrome embedder handler. ==========
The CQ bit was checked by pfeldman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from paulirish@chromium.org, alexclarke@chromium.org Link to the patchset: https://codereview.chromium.org/2140533003/#ps60001 (title: "headless test fixed")
The CQ bit was unchecked by nektar@chromium.org
The CQ bit was unchecked by nektar@chromium.org
The CQ bit was checked by pfeldman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by pfeldman@chromium.org
The CQ bit was checked by pfeldman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== DevTools: rename initialUrl to url in the Browser.createTarget protocol method, fix chrome embedder handler. ========== to ========== DevTools: rename initialUrl to url in the Browser.createTarget protocol method, fix chrome embedder handler. Committed: https://crrev.com/bfec2ff09dfb320ca7786402a804571a4baae37b Cr-Commit-Position: refs/heads/master@{#404886} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/bfec2ff09dfb320ca7786402a804571a4baae37b Cr-Commit-Position: refs/heads/master@{#404886} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
