Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Unified Diff: content/browser/devtools/protocol/devtools_protocol_browsertest.cc

Issue 2140533003: DevTools: rename initialUrl to url in the Browser.createTarget protocol method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: headless test fixed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/devtools_protocol_browsertest.cc
diff --git a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
index e6e83576d6626b1eab23df2ea201c6032e936fe0..858070b7014c8dde5409075cf9e990e16e8760d5 100644
--- a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
+++ b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
@@ -587,13 +587,13 @@ IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, JavaScriptDialogNotifications) {
dialog_manager.Handle();
}
-IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, BrowserNewPage) {
+IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, BrowserCreateTarget) {
NavigateToURLBlockUntilNavigationsComplete(shell(), GURL("about:blank"), 1);
Attach();
EXPECT_EQ(1u, shell()->windows().size());
std::unique_ptr<base::DictionaryValue> params(new base::DictionaryValue());
- params->SetString("initialUrl", "about:blank");
- SendCommand("Browser.newPage", std::move(params), true);
+ params->SetString("url", "about:blank");
+ SendCommand("Browser.createTarget", std::move(params), true);
EXPECT_EQ(2u, shell()->windows().size());
}
« no previous file with comments | « content/browser/devtools/protocol/browser_handler.cc ('k') | headless/lib/headless_devtools_client_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698