headless/lib/headless_devtools_client_browsertest.cc - Issue 2140533003: DevTools: rename initialUrl to url in the Browser.createTarget protocol method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/lib/headless_devtools_client_browsertest.cc

Issue 2140533003: DevTools: rename initialUrl to url in the Browser.createTarget protocol method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: headless test fixed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/protocol/devtools_protocol_browsertest.cc ('k') | third_party/WebKit/Source/core/inspector/browser_protocol.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: headless/lib/headless_devtools_client_browsertest.cc

diff --git a/headless/lib/headless_devtools_client_browsertest.cc b/headless/lib/headless_devtools_client_browsertest.cc

index daceba5d8a5ed4e448c424be81374589baf66e58..65e8145ad35272690a72c4c57d58962a083448a6 100644

--- a/headless/lib/headless_devtools_client_browsertest.cc

+++ b/headless/lib/headless_devtools_client_browsertest.cc

@@ -183,7 +183,7 @@ class BrowserDomainCreateAndDeletePageTest

devtools_client_->GetBrowser()->GetExperimental()->CreateTarget(

browser::CreateTargetParams::Builder()

- .SetInitialUrl(embedded_test_server()->GetURL("/hello.html").spec())

+ .SetUrl(embedded_test_server()->GetURL("/hello.html").spec())

.SetWidth(1)

.SetHeight(1)

.Build(),

@@ -229,7 +229,7 @@ class BrowserDomainDisposeContextFailsIfInUse

devtools_client_->GetBrowser()->GetExperimental()->CreateTarget(

browser::CreateTargetParams::Builder()

- .SetInitialUrl(embedded_test_server()->GetURL("/hello.html").spec())

+ .SetUrl(embedded_test_server()->GetURL("/hello.html").spec())

.SetBrowserContextId(context_id_)

.Build(),

base::Bind(

@@ -323,7 +323,7 @@ class BrowserDomainCreateTwoContexts : public HeadlessAsyncDevTooledBrowserTest,

devtools_client_->GetBrowser()->GetExperimental()->CreateTarget(

browser::CreateTargetParams::Builder()

- .SetInitialUrl(embedded_test_server()->GetURL("/hello.html").spec())

+ .SetUrl(embedded_test_server()->GetURL("/hello.html").spec())

.SetBrowserContextId(context_id_one_)

.Build(),

base::Bind(&BrowserDomainCreateTwoContexts::OnCreateTargetOneResult,

@@ -331,7 +331,7 @@ class BrowserDomainCreateTwoContexts : public HeadlessAsyncDevTooledBrowserTest,

devtools_client_->GetBrowser()->GetExperimental()->CreateTarget(

browser::CreateTargetParams::Builder()

- .SetInitialUrl(embedded_test_server()->GetURL("/hello.html").spec())

+ .SetUrl(embedded_test_server()->GetURL("/hello.html").spec())

.SetBrowserContextId(context_id_two_)

.Build(),

base::Bind(&BrowserDomainCreateTwoContexts::OnCreateTargetTwoResult,