content/browser/devtools/protocol/browser_handler.h - Issue 2140533003: DevTools: rename initialUrl to url in the Browser.createTarget protocol method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/browser_handler.h

Issue 2140533003: DevTools: rename initialUrl to url in the Browser.createTarget protocol method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: headless test fixed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/devtools_discovery/devtools_discovery_manager.cc ('k') | content/browser/devtools/protocol/browser_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/protocol/browser_handler.h

diff --git a/content/browser/devtools/protocol/browser_handler.h b/content/browser/devtools/protocol/browser_handler.h

index 3cf34de759182815171a48951d0da10f30aa62d3..ee14bfd9177fbaf2b14e28d456f12c11a57bb580 100644

--- a/content/browser/devtools/protocol/browser_handler.h

+++ b/content/browser/devtools/protocol/browser_handler.h

@@ -37,7 +37,7 @@ class BrowserHandler : public DevToolsAgentHostClient {

Response CreateBrowserContext(std::string* out_context_id);

Response DisposeBrowserContext(const std::string& context_id,

bool* out_success);

- Response CreateTarget(const std::string& initial_url,

+ Response CreateTarget(const std::string& url,

const int* width,

const int* height,

const std::string* context_id,