Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Side by Side Diff: content/browser/devtools/protocol/browser_handler.cc

Issue 2140533003: DevTools: rename initialUrl to url in the Browser.createTarget protocol method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: headless test fixed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/devtools/protocol/browser_handler.h" 5 #include "content/browser/devtools/protocol/browser_handler.h"
6 6
7 namespace content { 7 namespace content {
8 namespace devtools { 8 namespace devtools {
9 namespace browser { 9 namespace browser {
10 10
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 return Response::ServerError("Not supported"); 49 return Response::ServerError("Not supported");
50 } 50 }
51 51
52 Response BrowserHandler::DisposeBrowserContext(const std::string& context_id, 52 Response BrowserHandler::DisposeBrowserContext(const std::string& context_id,
53 bool* out_success) { 53 bool* out_success) {
54 // For layering reasons this needs to be handled by 54 // For layering reasons this needs to be handled by
55 // DevToolsManagerDelegate::HandleCommand. 55 // DevToolsManagerDelegate::HandleCommand.
56 return Response::ServerError("Not supported"); 56 return Response::ServerError("Not supported");
57 } 57 }
58 58
59 Response BrowserHandler::CreateTarget(const std::string& initial_url, 59 Response BrowserHandler::CreateTarget(const std::string& url,
60 const int* width, 60 const int* width,
61 const int* height, 61 const int* height,
62 const std::string* context_id, 62 const std::string* context_id,
63 std::string* out_target_id) { 63 std::string* out_target_id) {
64 // For layering reasons this needs to be handled by 64 // For layering reasons this needs to be handled by
65 // DevToolsManagerDelegate::HandleCommand. 65 // DevToolsManagerDelegate::HandleCommand.
66 return Response::ServerError("Not supported"); 66 return Response::ServerError("Not supported");
67 } 67 }
68 68
69 Response BrowserHandler::CloseTarget(const std::string& target_id, 69 Response BrowserHandler::CloseTarget(const std::string& target_id,
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 set_message(message)); 128 set_message(message));
129 } 129 }
130 130
131 void BrowserHandler::AgentHostClosed(DevToolsAgentHost* agent_host, 131 void BrowserHandler::AgentHostClosed(DevToolsAgentHost* agent_host,
132 bool replaced_with_another_client) { 132 bool replaced_with_another_client) {
133 } 133 }
134 134
135 } // namespace browser 135 } // namespace browser
136 } // namespace devtools 136 } // namespace devtools
137 } // namespace content 137 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698