Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9298)

Unified Diff: components/devtools_discovery/devtools_discovery_manager.cc

Issue 2140533003: DevTools: rename initialUrl to url in the Browser.createTarget protocol method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: headless test fixed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/devtools/protocol/browser_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/devtools_discovery/devtools_discovery_manager.cc
diff --git a/components/devtools_discovery/devtools_discovery_manager.cc b/components/devtools_discovery/devtools_discovery_manager.cc
index 3233085aecb88d9d8538205f0b0b6b1113b0df32..7953b6c933c797a900705644bacc33f79df9f5a0 100644
--- a/components/devtools_discovery/devtools_discovery_manager.cc
+++ b/components/devtools_discovery/devtools_discovery_manager.cc
@@ -67,15 +67,15 @@ DevToolsDiscoveryManager::HandleNewTargetCommand(
base::DictionaryValue* command_dict) {
int id;
std::string method;
- std::string initial_url;
+ std::string url;
const base::DictionaryValue* params_dict = nullptr;
if (command_dict->GetInteger("id", &id) &&
command_dict->GetString("method", &method) &&
- method == "Browser.newPage" &&
+ method == "Browser.createTarget" &&
command_dict->GetDictionary("params", &params_dict) &&
- params_dict->GetString("initialUrl", &initial_url)) {
+ params_dict->GetString("url", &url)) {
std::unique_ptr<devtools_discovery::DevToolsTargetDescriptor> descriptor =
- CreateNew(GURL(initial_url));
+ CreateNew(GURL(url));
if (!descriptor)
return nullptr;
std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue());
« no previous file with comments | « no previous file | content/browser/devtools/protocol/browser_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698