Remove WebURLRequest::initialize() and simplify WebURLRequest

Remove WebURLRequest::initialize() and simplify WebURLRequest

Does the same as we did for WebURLResponse in https://crrev.com/2117313002 and
https://crrev.com/2133693002.

BUG=625529
TBR=jochen@chromium.org for components

Committed: https://crrev.com/a2b5c2e4f27582316b4bb7d55d1a456ef8480aca
Cr-Commit-Position: refs/heads/master@{#404894}

[kinuko, 2016-07-11 08:59:25]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[kinuko, 2016-07-11 08:59:29]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-07-11 08:59:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinuko, 2016-07-11 09:05:28]

Description was changed from

==========
Remove WebURLRequest::initialize() and simplify WebURLRequest

Does the same as we did for WebURLResponse in crrev.com/2117313002 and
crrev.com/2133693002.

BUG=625529
==========

to

==========
Remove WebURLRequest::initialize() and simplify WebURLRequest

Does the same as we did for WebURLResponse in https://crrev.com/2117313002 and
https://crrev.com/2133693002.

BUG=625529
==========

[commit-bot: I haz the power, 2016-07-11 09:13:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 09:13:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[kinuko, 2016-07-11 09:32:19]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-11 09:32:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinuko, 2016-07-11 09:41:32]

kinuko@chromium.org changed reviewers:
+ dcheng@chromium.org, ricea@chromium.org

[kinuko, 2016-07-11 09:42:20]

Similar cleanup for WebURLRequest... PTL

[commit-bot: I haz the power, 2016-07-11 09:45:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 09:45:21]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dcheng, 2016-07-11 09:47:50]

https://codereview.chromium.org/2140523002/diff/40001/content/renderer/fetche...
File content/renderer/fetchers/resource_fetcher_impl.cc (right):

https://codereview.chromium.org/2140523002/diff/40001/content/renderer/fetche...
content/renderer/fetchers/resource_fetcher_impl.cc:126: request_.setURL(GURL());
It's a bit unexpected that this is the right way to 'reset' the request. This
would leave all the other state on the WebURLRequest as-is, right? I'm guessing
that's probably OK, but it's not the easiest for someone who doesn't know the
code (like me =) to understand.

Do you think it's worth writing this as request_ = WebURLRequest() instead, or
still providing a reset() method that does the same?

https://codereview.chromium.org/2140523002/diff/40001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/WebURLRequest.h (right):

https://codereview.chromium.org/2140523002/diff/40001/third_party/WebKit/publ...
third_party/WebKit/public/platform/WebURLRequest.h:317: BLINK_PLATFORM_EXPORT
explicit WebURLRequest(ResourceRequest*);
Nit: make this a mutable ref

[kinuko, 2016-07-11 09:54:23]

https://codereview.chromium.org/2140523002/diff/40001/content/renderer/fetche...
File content/renderer/fetchers/resource_fetcher_impl.cc (right):

https://codereview.chromium.org/2140523002/diff/40001/content/renderer/fetche...
content/renderer/fetchers/resource_fetcher_impl.cc:126: request_.setURL(GURL());
On 2016/07/11 09:47:50, dcheng wrote:
> It's a bit unexpected that this is the right way to 'reset' the request. This
> would leave all the other state on the WebURLRequest as-is, right? I'm
guessing
> that's probably OK, but it's not the easiest for someone who doesn't know the
> code (like me =) to understand.
> 
> Do you think it's worth writing this as request_ = WebURLRequest() instead, or
> still providing a reset() method that does the same?

Yup you're right this change is probably not quite right... I wondered if I
should do this or that.  Let me think about it and update.

[kinuko, 2016-07-11 13:47:31]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-11 13:47:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 13:59:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 13:59:50]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[kinuko, 2016-07-11 14:33:38]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-11 14:33:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinuko, 2016-07-11 14:33:55]

Patchset #3 (id:60001) has been deleted

[commit-bot: I haz the power, 2016-07-11 15:54:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 15:54:06]

Dry run: This issue passed the CQ dry run.

[kinuko, 2016-07-12 02:41:22]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 02:42:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 02:59:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 02:59:21]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[kinuko, 2016-07-12 03:10:24]

Patchset #4 (id:100001) has been deleted

[kinuko, 2016-07-12 03:10:34]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 03:11:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Adam Rice, 2016-07-12 04:17:55]

lgtm

[kinuko, 2016-07-12 04:19:57]

Thanks Adam.  dcheng - ptal

https://codereview.chromium.org/2140523002/diff/40001/content/renderer/fetche...
File content/renderer/fetchers/resource_fetcher_impl.cc (right):

https://codereview.chromium.org/2140523002/diff/40001/content/renderer/fetche...
content/renderer/fetchers/resource_fetcher_impl.cc:126: request_.setURL(GURL());
On 2016/07/11 09:47:50, dcheng wrote:
> It's a bit unexpected that this is the right way to 'reset' the request. This
> would leave all the other state on the WebURLRequest as-is, right? I'm
guessing
> that's probably OK, but it's not the easiest for someone who doesn't know the
> code (like me =) to understand.
> 
> Do you think it's worth writing this as request_ = WebURLRequest() instead, or
> still providing a reset() method that does the same?

Took the path to simply do request_ = WebURLRequest().

https://codereview.chromium.org/2140523002/diff/40001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/WebURLRequest.h (right):

https://codereview.chromium.org/2140523002/diff/40001/third_party/WebKit/publ...
third_party/WebKit/public/platform/WebURLRequest.h:317: BLINK_PLATFORM_EXPORT
explicit WebURLRequest(ResourceRequest*);
On 2016/07/11 09:47:50, dcheng wrote:
> Nit: make this a mutable ref

Done.

[dcheng, 2016-07-12 04:46:55]

LGTM

[commit-bot: I haz the power, 2016-07-12 04:47:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 04:47:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kinuko, 2016-07-12 04:48:09]

Description was changed from

==========
Remove WebURLRequest::initialize() and simplify WebURLRequest

Does the same as we did for WebURLResponse in https://crrev.com/2117313002 and
https://crrev.com/2133693002.

BUG=625529
==========

to

==========
Remove WebURLRequest::initialize() and simplify WebURLRequest

Does the same as we did for WebURLResponse in https://crrev.com/2117313002 and
https://crrev.com/2133693002.

BUG=625529
TBR=jochen@chromium.org for components
==========

[kinuko, 2016-07-12 04:48:25]

kinuko@chromium.org changed reviewers:
+ jochen@chromium.org

[kinuko, 2016-07-12 05:30:18]

TBR-ing jochen@ for refactoring-related one-liner changes in components/.  (Feel
free to uncheck CQ if it doesn't look right)

[kinuko, 2016-07-12 05:30:26]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2016-07-12 05:32:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 08:22:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 08:22:16]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kinuko, 2016-07-12 08:37:15]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2016-07-12 08:37:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 10:57:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 10:57:23]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jochen (gone - plz use gerrit), 2016-07-12 15:15:44]

lgtm

[kinuko, 2016-07-13 00:24:06]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2016-07-13 00:27:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 02:12:52]

Description was changed from

==========
Remove WebURLRequest::initialize() and simplify WebURLRequest

Does the same as we did for WebURLResponse in https://crrev.com/2117313002 and
https://crrev.com/2133693002.

BUG=625529
TBR=jochen@chromium.org for components
==========

to

==========
Remove WebURLRequest::initialize() and simplify WebURLRequest

Does the same as we did for WebURLResponse in https://crrev.com/2117313002 and
https://crrev.com/2133693002.

BUG=625529
TBR=jochen@chromium.org for components
==========

[commit-bot: I haz the power, 2016-07-13 02:12:53]

Committed patchset #4 (id:120001)

[commit-bot: I haz the power, 2016-07-13 02:14:11]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 02:15:03]

Description was changed from

==========
Remove WebURLRequest::initialize() and simplify WebURLRequest

Does the same as we did for WebURLResponse in https://crrev.com/2117313002 and
https://crrev.com/2133693002.

BUG=625529
TBR=jochen@chromium.org for components
==========

to

==========
Remove WebURLRequest::initialize() and simplify WebURLRequest

Does the same as we did for WebURLResponse in https://crrev.com/2117313002 and
https://crrev.com/2133693002.

BUG=625529
TBR=jochen@chromium.org for components

Committed: https://crrev.com/a2b5c2e4f27582316b4bb7d55d1a456ef8480aca
Cr-Commit-Position: refs/heads/master@{#404894}
==========

[commit-bot: I haz the power, 2016-07-13 02:15:04]

Patchset 4 (id:??) landed as
https://crrev.com/a2b5c2e4f27582316b4bb7d55d1a456ef8480aca
Cr-Commit-Position: refs/heads/master@{#404894}