Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Unified Diff: content/child/web_url_loader_impl_unittest.cc

Issue 2140523002: Remove WebURLRequest::initialize() and simplify WebURLRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mutable ref Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/web_url_loader_impl.cc ('k') | content/renderer/fetchers/resource_fetcher_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/web_url_loader_impl_unittest.cc
diff --git a/content/child/web_url_loader_impl_unittest.cc b/content/child/web_url_loader_impl_unittest.cc
index d71e1aaf38fea983922f357a663496d06864e2e2..8168d0f2da7c806e227b3d7630d654598b0eb4e3 100644
--- a/content/child/web_url_loader_impl_unittest.cc
+++ b/content/child/web_url_loader_impl_unittest.cc
@@ -277,7 +277,6 @@ class WebURLLoaderImplTest : public testing::Test {
void DoStartAsyncRequest() {
blink::WebURLRequest request;
- request.initialize();
request.setURL(GURL(kTestURL));
client()->loader()->loadAsynchronously(request, client());
ASSERT_TRUE(peer());
@@ -286,7 +285,6 @@ class WebURLLoaderImplTest : public testing::Test {
void DoStartAsyncRequestWithPriority(
blink::WebURLRequest::Priority priority) {
blink::WebURLRequest request;
- request.initialize();
request.setPriority(priority);
request.setURL(GURL(kTestURL));
client()->loader()->loadAsynchronously(request, client());
@@ -446,7 +444,6 @@ TEST_F(WebURLLoaderImplTest, DeleteOnFail) {
TEST_F(WebURLLoaderImplTest, DeleteBeforeResponseDataURL) {
blink::WebURLRequest request;
- request.initialize();
request.setURL(GURL("data:text/html;charset=utf-8,blah!"));
client()->loader()->loadAsynchronously(request, client());
client()->DeleteLoader();
@@ -458,7 +455,6 @@ TEST_F(WebURLLoaderImplTest, DeleteBeforeResponseDataURL) {
TEST_F(WebURLLoaderImplTest, DataURL) {
blink::WebURLRequest request;
- request.initialize();
request.setURL(GURL("data:text/html;charset=utf-8,blah!"));
client()->loader()->loadAsynchronously(request, client());
base::RunLoop().RunUntilIdle();
@@ -470,7 +466,6 @@ TEST_F(WebURLLoaderImplTest, DataURL) {
TEST_F(WebURLLoaderImplTest, DataURLDeleteOnReceiveResponse) {
blink::WebURLRequest request;
- request.initialize();
request.setURL(GURL("data:text/html;charset=utf-8,blah!"));
client()->set_delete_on_receive_response();
client()->loader()->loadAsynchronously(request, client());
@@ -482,7 +477,6 @@ TEST_F(WebURLLoaderImplTest, DataURLDeleteOnReceiveResponse) {
TEST_F(WebURLLoaderImplTest, DataURLDeleteOnReceiveData) {
blink::WebURLRequest request;
- request.initialize();
request.setURL(GURL("data:text/html;charset=utf-8,blah!"));
client()->set_delete_on_receive_data();
client()->loader()->loadAsynchronously(request, client());
@@ -494,7 +488,6 @@ TEST_F(WebURLLoaderImplTest, DataURLDeleteOnReceiveData) {
TEST_F(WebURLLoaderImplTest, DataURLDeleteOnFinish) {
blink::WebURLRequest request;
- request.initialize();
request.setURL(GURL("data:text/html;charset=utf-8,blah!"));
client()->set_delete_on_finish();
client()->loader()->loadAsynchronously(request, client());
@@ -506,7 +499,6 @@ TEST_F(WebURLLoaderImplTest, DataURLDeleteOnFinish) {
TEST_F(WebURLLoaderImplTest, DataURLDefersLoading) {
blink::WebURLRequest request;
- request.initialize();
request.setURL(GURL("data:text/html;charset=utf-8,blah!"));
client()->loader()->loadAsynchronously(request, client());
@@ -614,7 +606,6 @@ TEST_F(WebURLLoaderImplTest, BrowserSideNavigationCommit) {
const GURL kStreamURL = GURL("http://bar");
const std::string kMimeType = "text/html";
blink::WebURLRequest request;
- request.initialize();
request.setURL(kNavigationURL);
request.setFrameType(blink::WebURLRequest::FrameTypeTopLevel);
request.setRequestContext(blink::WebURLRequest::RequestContextFrame);
« no previous file with comments | « content/child/web_url_loader_impl.cc ('k') | content/renderer/fetchers/resource_fetcher_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698