Remove WebURLRequest::initialize() and simplify WebURLRequest

content/renderer/fetchers/resource_fetcher_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/fetchers/resource_fetcher_impl.h"
 
 #include "base/logging.h"
 #include "base/strings/string_util.h"
 #include "base/time/time.h"
 #include "third_party/WebKit/public/platform/Platform.h"
@@ skipping 104 matching lines @@
   switch (loader_type) {
     case PLATFORM_LOADER:
       loader_.reset(blink::Platform::current()->createURLLoader());
       break;
     case FRAME_ASSOCIATED_LOADER:
       loader_.reset(frame->createAssociatedURLLoader(options_));
       break;
   }
   loader_->loadAsynchronously(request_, this);
 
-  // No need to hold on to the request.
-  request_.reset();
+  // Reset the request.
+  request_.setURL(GURL());

[dcheng, 2016/07/11 09:47:50]

It's a bit unexpected that this is the right way to 'reset' the request. This
would leave all the other state on the WebURLRequest as-is, right? I'm guessing
that's probably OK, but it's not the easiest for someone who doesn't know the
code (like me =) to understand.

Do you think it's worth writing this as request_ = WebURLRequest() instead, or
still providing a reset() method that does the same?

[kinuko, 2016/07/11 09:54:23]

Yup you're right this change is probably not quite right... I wondered if I
should do this or that.  Let me think about it and update.

[kinuko, 2016/07/12 04:19:57]

Took the path to simply do request_ = WebURLRequest().

 }
 
 void ResourceFetcherImpl::SetTimeout(const base::TimeDelta& timeout) {
   DCHECK(loader_);
   DCHECK(!completed());
 
   timeout_timer_.Start(FROM_HERE, timeout, this, &ResourceFetcherImpl::Cancel);
 }
 
 void ResourceFetcherImpl::OnLoadComplete() {
   timeout_timer_.Stop();
   if (callback_.is_null())
     return;
 
   // Take a reference to the callback as running the callback may lead to our
   // destruction.
   Callback callback = callback_;
   callback.Run(status() == LOAD_FAILED ? blink::WebURLResponse() : response(),
                status() == LOAD_FAILED ? std::string() : data());
 }
 
 void ResourceFetcherImpl::Cancel() {
   loader_->cancel();
   WebURLLoaderClientImpl::Cancel();
 }
 
 }  // namespace content