Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Side by Side Diff: third_party/WebKit/Source/platform/testing/weburl_loader_mock.cc

Issue 2140523002: Remove WebURLRequest::initialize() and simplify WebURLRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mutable ref Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/testing/weburl_loader_mock.h" 5 #include "platform/testing/weburl_loader_mock.h"
6 6
7 #include "platform/testing/weburl_loader_mock_factory_impl.h" 7 #include "platform/testing/weburl_loader_mock_factory_impl.h"
8 #include "public/platform/URLConversion.h" 8 #include "public/platform/URLConversion.h"
9 #include "public/platform/WebData.h" 9 #include "public/platform/WebData.h"
10 #include "public/platform/WebURLError.h" 10 #include "public/platform/WebURLError.h"
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 delegate->didFinishLoading(client_, this, 0, data.size()); 60 delegate->didFinishLoading(client_, this, 0, data.size());
61 } 61 }
62 62
63 WebURLRequest WebURLLoaderMock::ServeRedirect( 63 WebURLRequest WebURLLoaderMock::ServeRedirect(
64 const WebURLRequest& request, 64 const WebURLRequest& request,
65 const WebURLResponse& redirectResponse) { 65 const WebURLResponse& redirectResponse) {
66 KURL redirectURL( 66 KURL redirectURL(
67 ParsedURLString, redirectResponse.httpHeaderField("Location")); 67 ParsedURLString, redirectResponse.httpHeaderField("Location"));
68 68
69 WebURLRequest newRequest; 69 WebURLRequest newRequest;
70 newRequest.initialize();
71 newRequest.setURL(redirectURL); 70 newRequest.setURL(redirectURL);
72 newRequest.setFirstPartyForCookies(redirectURL); 71 newRequest.setFirstPartyForCookies(redirectURL);
73 newRequest.setDownloadToFile(request.downloadToFile()); 72 newRequest.setDownloadToFile(request.downloadToFile());
74 newRequest.setUseStreamOnResponse(request.useStreamOnResponse()); 73 newRequest.setUseStreamOnResponse(request.useStreamOnResponse());
75 newRequest.setRequestContext(request.getRequestContext()); 74 newRequest.setRequestContext(request.getRequestContext());
76 newRequest.setFrameType(request.getFrameType()); 75 newRequest.setFrameType(request.getFrameType());
77 newRequest.setSkipServiceWorker(request.skipServiceWorker()); 76 newRequest.setSkipServiceWorker(request.skipServiceWorker());
78 newRequest.setShouldResetAppCache(request.shouldResetAppCache()); 77 newRequest.setShouldResetAppCache(request.shouldResetAppCache());
79 newRequest.setFetchRequestMode(request.getFetchRequestMode()); 78 newRequest.setFetchRequestMode(request.getFetchRequestMode());
80 newRequest.setFetchCredentialsMode(request.getFetchCredentialsMode()); 79 newRequest.setFetchCredentialsMode(request.getFetchCredentialsMode());
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 // In principle this is NOTIMPLEMENTED(), but if we put that here it floods 157 // In principle this is NOTIMPLEMENTED(), but if we put that here it floods
159 // the console during webkit unit tests, so we leave the function empty. 158 // the console during webkit unit tests, so we leave the function empty.
160 DCHECK(runner); 159 DCHECK(runner);
161 } 160 }
162 161
163 WeakPtr<WebURLLoaderMock> WebURLLoaderMock::GetWeakPtr() { 162 WeakPtr<WebURLLoaderMock> WebURLLoaderMock::GetWeakPtr() {
164 return weak_factory_.createWeakPtr(); 163 return weak_factory_.createWeakPtr();
165 } 164 }
166 165
167 } // namespace blink 166 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698