third_party/WebKit/Source/platform/exported/WebURLResponse.cpp - Issue 2140523002: Remove WebURLRequest::initialize() and simplify WebURLRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/exported/WebURLResponse.cpp

Issue 2140523002: Remove WebURLRequest::initialize() and simplify WebURLRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mutable ref Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/exported/WebURLRequestPrivate.h ('k') | third_party/WebKit/Source/platform/exported/WrappedResourceRequest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/exported/WebURLResponse.cpp

diff --git a/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp b/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp

index 0ffcd8bde954f34a599a12b2fcd5a3ba97f94955..f32971221b8cc353c30b140545ae065737d0d3f9 100644

--- a/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp

+++ b/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp

@@ -72,7 +72,7 @@ private:

struct WebURLResponse::ResourceResponseContainer {

ResourceResponseContainer() {}

- ResourceResponseContainer(const ResourceResponse& r)

+ explicit ResourceResponseContainer(const ResourceResponse& r)

: resourceResponse(r)

{

}

@@ -512,10 +512,9 @@ void WebURLResponse::setExtraData(WebURLResponse::ExtraData* extraData)

m_resourceResponse->setExtraData(ExtraDataContainer::create(extraData));

}

-WebURLResponse::WebURLResponse(ResourceResponse* p)

- : m_resourceResponse(p)

+WebURLResponse::WebURLResponse(ResourceResponse& r)

+ : m_resourceResponse(&r)

{

- DCHECK(p);

}

} // namespace blink