third_party/WebKit/Source/web/tests/WebFrameTest.cpp - Issue 2140523002: Remove WebURLRequest::initialize() and simplify WebURLRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2140523002: Remove WebURLRequest::initialize() and simplify WebURLRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mutable ref Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp ('k') | third_party/WebKit/Source/web/tests/WebURLRequestTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

index 12fa42170efcdce20439f7fbddd4b50aa80fb6ec..f4489c7da4fea1218acba254375a6992e1581d57 100644

--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

@@ -3320,7 +3320,6 @@ TEST_P(ParameterizedWebFrameTest, ReloadWhileProvisional)

FrameTestHelpers::WebViewHelper webViewHelper(this);

webViewHelper.initialize();

WebURLRequest request;

- request.initialize();

request.setURL(toKURL(m_baseURL + "fixed_layout.html"));

request.setRequestorOrigin(WebSecurityOrigin::createUnique());

webViewHelper.webView()->mainFrame()->loadRequest(request);

@@ -6288,7 +6287,6 @@ TEST_P(ParameterizedWebFrameTest, CurrentHistoryItem)

WebFrame* frame = webViewHelper.webView()->mainFrame();

const FrameLoader& mainFrameLoader = webViewHelper.webViewImpl()->mainFrameImpl()->frame()->loader();

WebURLRequest request;

- request.initialize();

request.setURL(toKURL(url));

request.setRequestorOrigin(WebSecurityOrigin::createUnique());

frame->loadRequest(request);

@@ -8808,7 +8806,6 @@ TEST_F(WebFrameTest, LoadJavascriptURLInNewFrame)

WebURLRequest request;

std::string redirectURL = m_baseURL + "foo.html";

URLTestHelpers::registerMockedURLLoad(toKURL(redirectURL), "foo.html");

- request.initialize();

request.setURL(toKURL("javascript:location='" + redirectURL + "'"));

request.setRequestorOrigin(WebSecurityOrigin::createUnique());

helper.webViewImpl()->mainFrame()->toWebLocalFrame()->loadRequest(request);