Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2138663003: Rename PageLifecycleObserver to PageVisibilityObserver (Closed)

Created:
4 years, 5 months ago by haraken
Modified:
4 years, 5 months ago
Reviewers:
dcheng
CC:
chromium-reviews, dshwang, mvanouwerkerk+watch_chromium.org, mlamouri+watch-blink_chromium.org, blink-reviews-html_chromium.org, timvolodine, haraken, ajuma+watch-canvas_chromium.org, dglazkov+blink, Rik, Justin Novosad, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename PageLifecycleObserver to PageVisibilityObserver Now that PageLifecycleObserver has only pageVisibilityChanged(), it would make more sense to rename the class accordingly. BUG=610176 Committed: https://crrev.com/13f83b3c919141de77bc6779cb793d37446b0ebe Cr-Commit-Position: refs/heads/master@{#404623}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -201 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/PlatformEventController.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/PlatformEventController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/page/PageLifecycleNotifier.h View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/WebKit/Source/core/page/PageLifecycleNotifier.cpp View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/Source/core/page/PageLifecycleObserver.h View 1 chunk +0 lines, -54 lines 0 comments Download
A + third_party/WebKit/Source/core/page/PageVisibilityNotifier.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/core/page/PageVisibilityNotifier.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/core/page/PageVisibilityObserver.h View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/geolocation/Geolocation.h View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/geolocation/Geolocation.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/nfc/NFC.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/nfc/NFC.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationAvailability.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationAvailability.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/vibration/VibrationController.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/vibration/VibrationController.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
haraken
PTAL
4 years, 5 months ago (2016-07-11 07:40:35 UTC) #2
dcheng
lgtm
4 years, 5 months ago (2016-07-11 07:45:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138663003/1
4 years, 5 months ago (2016-07-11 07:57:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 09:29:22 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 09:29:28 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 09:30:50 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/13f83b3c919141de77bc6779cb793d37446b0ebe
Cr-Commit-Position: refs/heads/master@{#404623}

Powered by Google App Engine
This is Rietveld 408576698