third_party/WebKit/Source/core/html/HTMLCanvasElement.h - Issue 2138663003: Rename PageLifecycleObserver to PageVisibilityObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLCanvasElement.h

Issue 2138663003: Rename PageLifecycleObserver to PageVisibilityObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/PlatformEventController.cpp ('k') | third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLCanvasElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLCanvasElement.h b/third_party/WebKit/Source/core/html/HTMLCanvasElement.h

index c337a6ea877a3593409654ef8ac69b0d8f5ee734..4abe0c5bb4bae9c84da0a7338843baa4a1dd8858 100644

--- a/third_party/WebKit/Source/core/html/HTMLCanvasElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLCanvasElement.h

@@ -38,7 +38,7 @@

#include "core/html/canvas/CanvasDrawListener.h"

#include "core/html/canvas/CanvasImageSource.h"

#include "core/imagebitmap/ImageBitmapSource.h"

-#include "core/page/PageLifecycleObserver.h"

+#include "core/page/PageVisibilityObserver.h"

#include "platform/geometry/FloatRect.h"

#include "platform/geometry/IntSize.h"

#include "platform/graphics/CanvasSurfaceLayerBridge.h"

@@ -68,7 +68,7 @@ class IntSize;

class CanvasRenderingContext2DOrWebGLRenderingContextOrWebGL2RenderingContextOrImageBitmapRenderingContext;

typedef CanvasRenderingContext2DOrWebGLRenderingContextOrWebGL2RenderingContextOrImageBitmapRenderingContext RenderingContext;

-class CORE_EXPORT HTMLCanvasElement final : public HTMLElement, public ContextLifecycleObserver, public PageLifecycleObserver, public CanvasImageSource, public ImageBufferClient, public ImageBitmapSource {

+class CORE_EXPORT HTMLCanvasElement final : public HTMLElement, public ContextLifecycleObserver, public PageVisibilityObserver, public CanvasImageSource, public ImageBufferClient, public ImageBitmapSource {

DEFINE_WRAPPERTYPEINFO();

USING_GARBAGE_COLLECTED_MIXIN(HTMLCanvasElement);

USING_PRE_FINALIZER(HTMLCanvasElement, dispose);

@@ -157,10 +157,10 @@ public:

InsertionNotificationRequest insertedInto(ContainerNode*) override;

- // ContextLifecycleObserver (and PageLifecycleObserver!!!) implementation

+ // ContextLifecycleObserver (and PageVisibilityObserver!!!) implementation

void contextDestroyed() override;

- // PageLifecycleObserver implementation

+ // PageVisibilityObserver implementation

void pageVisibilityChanged() override;

// CanvasImageSource implementation