third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.h - Issue 2138663003: Rename PageLifecycleObserver to PageVisibilityObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.h

Issue 2138663003: Rename PageLifecycleObserver to PageVisibilityObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/vibration/VibrationController.cpp ('k') | third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.h

diff --git a/third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.h b/third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.h

index 1e9e9ca77cddad15a585357e84a651c326730be8..04dc2143c1ce78237f7ae38145f4a8325df31891 100644

--- a/third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.h

+++ b/third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.h

@@ -6,7 +6,7 @@

#define ScreenWakeLock_h

#include "core/dom/ContextLifecycleObserver.h"

-#include "core/page/PageLifecycleObserver.h"

+#include "core/page/PageVisibilityObserver.h"

#include "modules/ModulesExport.h"

#include "public/platform/modules/wake_lock/wake_lock_service.mojom-blink.h"

#include "wtf/Noncopyable.h"

@@ -17,7 +17,7 @@ class LocalFrame;

class Screen;

class ServiceRegistry;

-class MODULES_EXPORT ScreenWakeLock final : public GarbageCollectedFinalized<ScreenWakeLock>, public Supplement<LocalFrame>, public ContextLifecycleObserver, public PageLifecycleObserver {

+class MODULES_EXPORT ScreenWakeLock final : public GarbageCollectedFinalized<ScreenWakeLock>, public Supplement<LocalFrame>, public ContextLifecycleObserver, public PageVisibilityObserver {

USING_GARBAGE_COLLECTED_MIXIN(ScreenWakeLock);

WTF_MAKE_NONCOPYABLE(ScreenWakeLock);

public:

@@ -34,7 +34,7 @@ public:

private:

explicit ScreenWakeLock(LocalFrame&);

- // Inherited from PageLifecycleObserver.

+ // Inherited from PageVisibilityObserver.

void pageVisibilityChanged() override;

void contextDestroyed() override;