third_party/WebKit/Source/modules/vibration/VibrationController.cpp - Issue 2138663003: Rename PageLifecycleObserver to PageVisibilityObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/vibration/VibrationController.cpp

Issue 2138663003: Rename PageLifecycleObserver to PageVisibilityObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/vibration/VibrationController.h ('k') | third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/vibration/VibrationController.cpp

diff --git a/third_party/WebKit/Source/modules/vibration/VibrationController.cpp b/third_party/WebKit/Source/modules/vibration/VibrationController.cpp

index 20f493ddf88453bad0a90490bc34a143eed3e3bb..e7a9542f6b1c5d4ccaddf950c3b55a928bddc6bd 100644

--- a/third_party/WebKit/Source/modules/vibration/VibrationController.cpp

+++ b/third_party/WebKit/Source/modules/vibration/VibrationController.cpp

@@ -74,7 +74,7 @@ VibrationController::VibrationPattern VibrationController::sanitizeVibrationPatt

VibrationController::VibrationController(Document& document)

: ContextLifecycleObserver(&document)

- , PageLifecycleObserver(document.page())

+ , PageVisibilityObserver(document.page())

, m_timerDoVibrate(this, &VibrationController::doVibrate)

, m_isRunning(false)

, m_isCallingCancel(false)

@@ -188,7 +188,7 @@ void VibrationController::contextDestroyed()

// Page outlives ExecutionContext so stop observing it to avoid having

// |pageVisibilityChanged| or |contextDestroyed| called again.

- PageLifecycleObserver::clearContext();

+ PageVisibilityObserver::clearContext();

}

void VibrationController::pageVisibilityChanged()

@@ -200,7 +200,7 @@ void VibrationController::pageVisibilityChanged()

DEFINE_TRACE(VibrationController)

{

ContextLifecycleObserver::trace(visitor);

- PageLifecycleObserver::trace(visitor);

+ PageVisibilityObserver::trace(visitor);

}

} // namespace blink