third_party/WebKit/Source/modules/nfc/NFC.cpp - Issue 2138663003: Rename PageLifecycleObserver to PageVisibilityObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/nfc/NFC.cpp

Issue 2138663003: Rename PageLifecycleObserver to PageVisibilityObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/nfc/NFC.h ('k') | third_party/WebKit/Source/modules/presentation/PresentationAvailability.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/nfc/NFC.cpp

diff --git a/third_party/WebKit/Source/modules/nfc/NFC.cpp b/third_party/WebKit/Source/modules/nfc/NFC.cpp

index 746341502c18e008054c40a110b0aa016bb21114..c3712d71d4c3b16d7504571ef7ddca3dc2db5e49 100644

--- a/third_party/WebKit/Source/modules/nfc/NFC.cpp

+++ b/third_party/WebKit/Source/modules/nfc/NFC.cpp

@@ -438,7 +438,7 @@ bool setURL(const String& origin, nfc::NFCMessagePtr& message)

} // anonymous namespace

NFC::NFC(LocalFrame* frame)

- : PageLifecycleObserver(frame->page())

+ : PageVisibilityObserver(frame->page())

, ContextLifecycleObserver(frame->document())

, m_client(this)

{

@@ -581,7 +581,7 @@ void NFC::OnWatch(mojo::WTFArray<uint32_t> ids, nfc::NFCMessagePtr)

DEFINE_TRACE(NFC)

{

- PageLifecycleObserver::trace(visitor);

+ PageVisibilityObserver::trace(visitor);

ContextLifecycleObserver::trace(visitor);

visitor->trace(m_requests);

}