third_party/WebKit/Source/modules/vibration/VibrationController.h - Issue 2138663003: Rename PageLifecycleObserver to PageVisibilityObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/vibration/VibrationController.h

Issue 2138663003: Rename PageLifecycleObserver to PageVisibilityObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/presentation/PresentationAvailability.cpp ('k') | third_party/WebKit/Source/modules/vibration/VibrationController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/vibration/VibrationController.h

diff --git a/third_party/WebKit/Source/modules/vibration/VibrationController.h b/third_party/WebKit/Source/modules/vibration/VibrationController.h

index 5d8696a6f5aaae56807c28a16f12601408f62743..1f836f1392e827fc79a51c2f2dc139259135ca5f 100644

--- a/third_party/WebKit/Source/modules/vibration/VibrationController.h

+++ b/third_party/WebKit/Source/modules/vibration/VibrationController.h

@@ -21,7 +21,7 @@

#define VibrationController_h

#include "core/dom/ContextLifecycleObserver.h"

-#include "core/page/PageLifecycleObserver.h"

+#include "core/page/PageVisibilityObserver.h"

#include "device/vibration/vibration_manager.mojom-blink.h"

#include "modules/ModulesExport.h"

#include "platform/Timer.h"

@@ -39,7 +39,7 @@ class UnsignedLongOrUnsignedLongSequence;

class MODULES_EXPORT VibrationController final

: public GarbageCollectedFinalized<VibrationController>

, public ContextLifecycleObserver

- , public PageLifecycleObserver {

+ , public PageVisibilityObserver {

USING_GARBAGE_COLLECTED_MIXIN(VibrationController);

WTF_MAKE_NONCOPYABLE(VibrationController);

public:

@@ -67,10 +67,10 @@ public:

DECLARE_VIRTUAL_TRACE();

private:

- // Inherited from ContextLifecycleObserver AND PageLifecycleObserver.

+ // Inherited from ContextLifecycleObserver AND PageVisibilityObserver.

void contextDestroyed() override;

- // Inherited from PageLifecycleObserver.

+ // Inherited from PageVisibilityObserver.

void pageVisibilityChanged() override;

// The VibrationManager mojo service. This is reset in |contextDestroyed|