Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2132593002: Remove remaining calls to deprecated MessageLoop methods on Mac. (Closed)

Created:
4 years, 5 months ago by fdoray
Modified:
4 years, 5 months ago
CC:
alokp+watch_chromium.org, asanka, blink-reviews, cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, chromoting-reviews_chromium.org, darin-cc_chromium.org, dbeam+watch-downloads_chromium.org, dcheng, devtools-reviews_chromium.org, Dmitry Titov, estade+watch_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, gavinp+memory_chromium.org, gcasto+watchlist_chromium.org, halliwell+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, jennb, jianli, kinuko+watch, lcwu+watch_chromium.org, markusheintz_, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, msramek+watch_chromium.org, nona+watch_chromium.org, noyau+watch_chromium.org, pfeldman, piman+watch_chromium.org, posciak+watch_chromium.org, rouslan+autofill_chromium.org, sadrul, scheduler-bugs_chromium.org, sdefresne+watch_chromium.org, shuchen+watch_chromium.org, James Su, sync-reviews_chromium.org, tfarina, vabr+watchlistpasswordmanager_chromium.org, vabr+watchlistautofill_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove remaining calls to deprecated MessageLoop methods on Mac. With this CL, there is no remaining call to these methods on Mac: - MessageLoop::PostTask - MessageLoop::PostDelayedTask - MessageLoop::ReleaseSoon - MessageLoop::DeleteSoon - MessageLoop::Run - MessageLoop::RunUntilIdle Note that this CL also removes calls to these methods from files that are not built on Mac. These calls were not migrated by the clang-tidy script used previously for various reasons (Objective-C code, templates, macros, header files, std::unique_ptr<MessageLoop>...). This CL was generated manually (with the help of a few regular expressions). BUG=616447 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel TBR=sdefresne@chromium.org (for ios/'s trivial application of this refactoring) Committed: https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d Cr-Commit-Position: refs/heads/master@{#406148}

Patch Set 1 #

Patch Set 2 : self-review #

Patch Set 3 : rebase #

Patch Set 4 : remove ios call sites #

Total comments: 7

Patch Set 5 : remove remaining calls #

Patch Set 6 : CR gab #

Patch Set 7 : CR gab #

Total comments: 2

Patch Set 8 : restore wait_util.mm #

Patch Set 9 : personal_data_manager_unittest.cc #

Patch Set 10 : h264_vt_encoder_unittest.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+423 lines, -367 lines) Patch
M base/files/file_path_watcher_unittest.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M base/ios/weak_nsobject_unittest.mm View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M base/memory/memory_pressure_listener_unittest.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M base/message_loop/message_loop_task_runner_unittest.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
M base/message_loop/message_loop_unittest.cc View 1 4 chunks +11 lines, -9 lines 0 comments Download
M base/message_loop/message_pump_glib_unittest.cc View 1 6 chunks +21 lines, -24 lines 0 comments Download
M chrome/app_shim/chrome_main_app_mode_mac.mm View 1 chunk +5 lines, -7 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_helper_browsertest.h View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/devtools/device/port_forwarding_browsertest.cc View 1 2 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 1 2 3 4 5 6 7 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm View 1 2 3 4 5 6 7 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac.mm View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state_unittest.mm View 1 3 chunks +24 lines, -18 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 1 2 3 4 5 6 7 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm View 1 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/first_run_dialog.mm View 1 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/importer/import_lock_dialog_cocoa.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/keystone_infobar_delegate.mm View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/one_click_signin_dialog_controller.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/panels/display_settings_provider_cocoa.mm View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_dialog_cocoa.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/status_bubble_mac.mm View 1 3 chunks +6 lines, -5 lines 0 comments Download
M chromecast/base/component/component_unittest.cc View 1 16 chunks +25 lines, -26 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/base/task_queue_manager_perftest.cc View 1 2 5 chunks +5 lines, -2 lines 0 comments Download
M components/scheduler/base/task_queue_manager_unittest.cc View 1 2 18 chunks +19 lines, -19 lines 0 comments Download
M components/scheduler/child/idle_helper_unittest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl_unittest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M components/search_provider_logos/logo_tracker_unittest.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M components/translate/ios/browser/ios_translate_driver.mm View 1 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_ui_controller_unittest.cc View 5 chunks +5 lines, -6 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager_unittest.cc View 26 chunks +32 lines, -32 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 3 4 5 6 7 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/text_input_client_mac_unittest.mm View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 4 5 6 7 3 chunks +6 lines, -6 lines 0 comments Download
M device/serial/serial_connection_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/cast_channel/cast_test_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/ipc/service/image_transport_surface_overlay_mac.mm View 2 chunks +2 lines, -1 line 0 comments Download
M ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm View 1 2 chunks +2 lines, -1 line 0 comments Download
M ios/chrome/browser/infobars/infobar_container_ios.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/passwords/credential_manager.mm View 1 2 3 4 5 6 7 3 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/signin/browser_state_data_remover.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ios/crnet/crnet_environment.mm View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M jingle/glue/chrome_async_socket_unittest.cc View 24 chunks +38 lines, -37 lines 0 comments Download
M jingle/notifier/base/xmpp_connection_unittest.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M media/audio/audio_input_controller_unittest.cc View 1 2 3 4 5 6 7 3 chunks +6 lines, -5 lines 0 comments Download
M media/audio/mac/audio_low_latency_input_mac_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/cast/sender/h264_vt_encoder_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_demuxer_unittest.cc View 1 2 3 4 4 chunks +7 lines, -7 lines 0 comments Download
M media/test/pipeline_integration_test.cc View 1 2 3 4 5 6 7 6 chunks +5 lines, -7 lines 0 comments Download
M net/proxy/proxy_config_service_android_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M net/test/embedded_test_server/embedded_test_server_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_message_loop_proxy.h View 1 2 3 4 5 3 chunks +7 lines, -0 lines 0 comments Download
M ppapi/proxy/ppb_message_loop_proxy.cc View 1 2 3 4 5 4 chunks +22 lines, -6 lines 0 comments Download
M remoting/client/client_status_logger_unittest.cc View 8 chunks +11 lines, -8 lines 0 comments Download
M remoting/host/host_status_logger_unittest.cc View 8 chunks +14 lines, -10 lines 0 comments Download
M services/shell/background/background_shell.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M sync/internal_api/public/attachments/task_queue.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/RunAllTests.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/test/scoped_fake_nswindow_fullscreen.mm View 3 chunks +5 lines, -2 lines 0 comments Download
M ui/base/test/ui_controls_mac.mm View 1 6 chunks +8 lines, -8 lines 0 comments Download
M ui/views/widget/native_widget_mac_unittest.mm View 1 2 3 4 5 6 7 2 chunks +3 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 48 (16 generated)
fdoray
gab@: Can you review this CL? Then, I'll need rubber stamp lgtms from owners: base/ ...
4 years, 5 months ago (2016-07-08 14:15:40 UTC) #5
bbudge
ppapi lgtm
4 years, 5 months ago (2016-07-08 14:51:26 UTC) #6
agl
LGTM for net/
4 years, 5 months ago (2016-07-08 15:27:52 UTC) #7
fdoray
gab@: Can you review this CL? Then, I'll need rubber stamp lgtms from owners: base/ ...
4 years, 5 months ago (2016-07-08 15:38:16 UTC) #9
Lei Zhang
https://codereview.chromium.org/2132593002/diff/50001/base/test/ios/wait_util.mm File base/test/ios/wait_util.mm (right): https://codereview.chromium.org/2132593002/diff/50001/base/test/ios/wait_util.mm#newcode31 base/test/ios/wait_util.mm:31: if (message_loop) { Can we, maybe in a follow ...
4 years, 5 months ago (2016-07-08 17:08:42 UTC) #10
Lei Zhang
base/ and chrome/ lgtm
4 years, 5 months ago (2016-07-08 17:10:02 UTC) #11
alokp
chromecast/ lgtm
4 years, 5 months ago (2016-07-08 17:14:58 UTC) #12
maxbogue
sync/ lgtm
4 years, 5 months ago (2016-07-08 17:28:18 UTC) #13
sadrul
ui/ lgtm
4 years, 5 months ago (2016-07-08 17:30:32 UTC) #14
Sergey Ulanov
remoting and jingle LGTM
4 years, 5 months ago (2016-07-08 17:31:00 UTC) #15
Reilly Grant (use Gerrit)
lgtm
4 years, 5 months ago (2016-07-08 17:50:06 UTC) #16
no sievers
gpu lgtm
4 years, 5 months ago (2016-07-08 17:55:45 UTC) #17
gab
lgtm w/ comments https://codereview.chromium.org/2132593002/diff/50001/content/renderer/render_thread_impl.cc File content/renderer/render_thread_impl.cc (right): https://codereview.chromium.org/2132593002/diff/50001/content/renderer/render_thread_impl.cc#newcode962 content/renderer/render_thread_impl.cc:962: if (main_message_loop_) This condition now looks ...
4 years, 5 months ago (2016-07-08 18:36:08 UTC) #18
chcunningham
lgtm % comment https://codereview.chromium.org/2132593002/diff/50001/media/test/pipeline_integration_test.cc File media/test/pipeline_integration_test.cc (right): https://codereview.chromium.org/2132593002/diff/50001/media/test/pipeline_integration_test.cc#newcode1761 media/test/pipeline_integration_test.cc:1761: message_loop_.Run(); Should this use RunLoop?
4 years, 5 months ago (2016-07-08 19:39:13 UTC) #19
fdoray
jochen@ and jam@: Can you review this CL? base/ thestig@chromium.org [done] chrome/ thestig@chromium.org [done] chromecast/ ...
4 years, 5 months ago (2016-07-08 20:19:04 UTC) #21
fdoray
jochen@ and jam@: Can you review this CL? base/ thestig@chromium.org [done] chrome/ thestig@chromium.org [done] chromecast/ ...
4 years, 5 months ago (2016-07-08 20:21:10 UTC) #22
fdoray
sdefresne@, jochen@ and jam@: Can you review this CL? base/ thestig@chromium.org [done] chrome/ thestig@chromium.org [done] ...
4 years, 5 months ago (2016-07-08 20:26:11 UTC) #23
jam
lgtm
4 years, 5 months ago (2016-07-09 02:52:41 UTC) #24
jam
On 2016/07/09 02:52:41, jam wrote: > lgtm btw you can TBR all these owners if ...
4 years, 5 months ago (2016-07-09 02:53:44 UTC) #25
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-11 14:30:24 UTC) #26
vinodsonkusare77_gmail.com
> > https://youtu.be/s2mEASqcipA > -- You received this message because you are subscribed to the ...
4 years, 5 months ago (2016-07-11 16:05:21 UTC) #27
vinodsonkusare77_gmail.com
> > https://youtu.be/s2mEASqcipA > -- You received this message because you are subscribed to the ...
4 years, 5 months ago (2016-07-11 16:05:21 UTC) #28
gab
Thanks everyone. TBR sdefresne for ios/'s trivial application of this refactoring (I'll CQ this on ...
4 years, 5 months ago (2016-07-11 18:05:30 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2132593002/110001
4 years, 5 months ago (2016-07-11 18:07:02 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/33617) ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 5 months ago (2016-07-11 18:10:32 UTC) #36
sdefresne
ios lgtm but maybe you want to split your CL in smaller parts If you ...
4 years, 5 months ago (2016-07-12 08:58:29 UTC) #37
fdoray
https://codereview.chromium.org/2132593002/diff/110001/base/test/ios/wait_util.mm File base/test/ios/wait_util.mm (right): https://codereview.chromium.org/2132593002/diff/110001/base/test/ios/wait_util.mm#newcode21 base/test/ios/wait_util.mm:21: MessageLoop* message_loop, On 2016/07/12 08:58:29, sdefresne wrote: > nit: ...
4 years, 5 months ago (2016-07-18 20:44:03 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2132593002/170001
4 years, 5 months ago (2016-07-18 20:44:32 UTC) #42
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-18 20:44:40 UTC) #43
commit-bot: I haz the power
Committed patchset #10 (id:170001)
4 years, 5 months ago (2016-07-18 23:47:33 UTC) #45
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 23:48:11 UTC) #46
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 23:50:11 UTC) #48
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/2df4a9ef0a0abb0c21d8994fe597c68f6637d95d
Cr-Commit-Position: refs/heads/master@{#406148}

Powered by Google App Engine
This is Rietveld 408576698