chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac.mm - Issue 2132593002: Remove remaining calls to deprecated MessageLoop methods on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac.mm

Issue 2132593002: Remove remaining calls to deprecated MessageLoop methods on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: h264_vt_encoder_unittest.cc Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm ('k') | chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac.mm

diff --git a/chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac.mm b/chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac.mm

index efb348592403b6d71ec5bb26df9e8a22228c3c9a..1da50bbb78bbd4842da50c4512261a9ea16794f9 100644

--- a/chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac.mm

+++ b/chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac.mm

@@ -8,6 +8,7 @@

#include "base/mac/scoped_nsautorelease_pool.h"

#include "base/strings/sys_string_conversions.h"

#include "base/strings/utf_string_conversions.h"

+#include "base/threading/thread_task_runner_handle.h"

#include "chrome/app/chrome_command_ids.h"

#include "chrome/browser/apps/app_shim/extension_app_shim_handler_mac.h"

#include "chrome/browser/apps/app_window_registry_util.h"

@@ -535,7 +536,7 @@ void SetChromeCyclesWindows(int sequence_number) {

appId_ = app->id();

[self addMenuItems:app];

if (IsAppWindowCyclingEnabled()) {

- base::MessageLoop::current()->PostTask(

+ base::ThreadTaskRunnerHandle::Get()->PostTask(

FROM_HERE, base::Bind(&SetAppCyclesWindows, appId_,

++g_window_cycle_sequence_number));

}

@@ -548,7 +549,7 @@ void SetChromeCyclesWindows(int sequence_number) {

appId_.clear();

[self removeMenuItems];

if (IsAppWindowCyclingEnabled()) {

- base::MessageLoop::current()->PostTask(

+ base::ThreadTaskRunnerHandle::Get()->PostTask(

FROM_HERE,

base::Bind(&SetChromeCyclesWindows, ++g_window_cycle_sequence_number));

}