chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm - Issue 2132593002: Remove remaining calls to deprecated MessageLoop methods on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm

Issue 2132593002: Remove remaining calls to deprecated MessageLoop methods on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: h264_vt_encoder_unittest.cc Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm ('k') | chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm b/chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm

index a181d9acc805c2a016ee874d66ded5b69427080f..0de045236aeebeb8fb0619022f52b331fc33fec9 100644

--- a/chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm

@@ -11,6 +11,7 @@

#import "base/mac/scoped_block.h"

#import "base/mac/scoped_nsobject.h"

+#include "base/run_loop.h"

#include "chrome/browser/download/download_shelf.h"

#include "chrome/browser/ui/cocoa/cocoa_profile_test.h"

#import "chrome/browser/ui/cocoa/download/download_item_controller.h"

@@ -391,11 +392,14 @@ TEST_F(DownloadShelfControllerTest, ViewVisibility) {

[shelf_ showDownloadShelf:YES isUserAction:NO];

EXPECT_FALSE([[shelf_ view] isHidden]);

+ base::RunLoop run_loop;

+ base::RunLoop* const run_loop_ptr = &run_loop;

[shelf_ setCloseAnimationHandler:^{

- base::MessageLoop::current()->QuitNow();

+ run_loop_ptr->Quit();

}];

[shelf_ showDownloadShelf:NO isUserAction:NO];

- base::MessageLoop::current()->Run();

+ run_loop.Run();

EXPECT_TRUE([[shelf_ view] isHidden]);

[shelf_ showDownloadShelf:YES isUserAction:NO];