Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 2155223002: Remove deprecated methods from MessageLoop on Mac. (Closed)

Created:
4 years, 5 months ago by fdoray
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_msg_loop
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated methods from MessageLoop on Mac. This CL removes the declaration of these deprecated methods on Mac: - MessageLoop::PostTask - MessageLoop::PostDelayedTask - MessageLoop::ReleaseSoon - MessageLoop::DeleteSoon And makes these methods protected on Mac: - MessageLoop::Run - MessageLoop::RunUntilIdle (These methods are protected instead of removed because they are still used through derived classes.) We believe that this CL will prevent developers from adding new calls to the deprecated methods (since the code won't compile on Mac bots). We will remove these methods on other platforms as soon as possible. BUG=616447 Committed: https://crrev.com/c08014da520a3193d91ba87ec0f4ae30d9e79c61 Cr-Commit-Position: refs/heads/master@{#406360}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M base/message_loop/message_loop.h View 7 chunks +18 lines, -0 lines 0 comments Download
M base/message_loop/message_loop.cc View 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
fdoray
Can you review this CL? Thanks.
4 years, 5 months ago (2016-07-18 18:23:45 UTC) #5
Lei Zhang
Looking... Oh, I see there's some trouble landing https://codereview.chromium.org/2132593002 - should have tried over the ...
4 years, 5 months ago (2016-07-18 20:39:09 UTC) #8
Lei Zhang
https://codereview.chromium.org/2155223002/diff/1/base/message_loop/message_loop.h File base/message_loop/message_loop.h (right): https://codereview.chromium.org/2155223002/diff/1/base/message_loop/message_loop.h#newcode584 base/message_loop/message_loop.h:584: using MessageLoop::Run; Are these needed? I built base_unittests on ...
4 years, 5 months ago (2016-07-18 20:42:48 UTC) #9
fdoray
PTAnL https://codereview.chromium.org/2155223002/diff/1/base/message_loop/message_loop.h File base/message_loop/message_loop.h (right): https://codereview.chromium.org/2155223002/diff/1/base/message_loop/message_loop.h#newcode584 base/message_loop/message_loop.h:584: using MessageLoop::Run; On 2016/07/18 20:42:48, Lei Zhang wrote: ...
4 years, 5 months ago (2016-07-19 15:09:56 UTC) #10
Lei Zhang
ok, lgtm and happy refactoring.
4 years, 5 months ago (2016-07-19 17:28:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155223002/20001
4 years, 5 months ago (2016-07-19 18:28:25 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-19 20:05:27 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 20:05:36 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 20:07:57 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c08014da520a3193d91ba87ec0f4ae30d9e79c61
Cr-Commit-Position: refs/heads/master@{#406360}

Powered by Google App Engine
This is Rietveld 408576698