chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm - Issue 2132593002: Remove remaining calls to deprecated MessageLoop methods on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm

Issue 2132593002: Remove remaining calls to deprecated MessageLoop methods on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: h264_vt_encoder_unittest.cc Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm ('k') | chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm

diff --git a/chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm b/chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm

index b219e9df3d9572aa73ff5ac6040e7da85a29b605..a74888cf0e51183eece535b7cbf4f1e30ffff14b 100644

--- a/chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm

+++ b/chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm

@@ -12,9 +12,9 @@

#include "base/callback.h"

#include "base/callback_helpers.h"

#include "base/macros.h"

-#include "base/message_loop/message_loop.h"

#include "base/strings/stringprintf.h"

#include "base/strings/utf_string_conversions.h"

+#include "base/threading/thread_task_runner_handle.h"

#include "chrome/browser/extensions/extension_action_test_util.h"

#include "chrome/browser/extensions/extension_browsertest.h"

#include "chrome/browser/extensions/extension_service.h"

@@ -184,14 +184,14 @@ void MoveMouseToCenter(NSView* view) {

- (void)menuDidClose:(NSNotification*)notification {

if (!closeClosure_.is_null()) {

- base::MessageLoop::current()->PostTask(

+ base::ThreadTaskRunnerHandle::Get()->PostTask(

FROM_HERE, base::ResetAndReturn(&closeClosure_));

}

- (void)menuDidOpen:(NSNotification*)notification {

if (!openClosure_.is_null()) {

- base::MessageLoop::current()->PostTask(

+ base::ThreadTaskRunnerHandle::Get()->PostTask(

FROM_HERE, base::ResetAndReturn(&openClosure_));

}

@@ -271,7 +271,7 @@ void ClickOnOverflowedAction(ToolbarController* toolbarController,

// This should close the app menu.

EXPECT_FALSE([appMenuController isMenuOpen]);

- base::MessageLoop::current()->PostTask(FROM_HERE, closure);

+ base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, closure);

}

// Verifies that the action is "popped out" of overflow; that is, it is visible

@@ -435,7 +435,7 @@ void CheckAppMenuLayout(ToolbarController* toolbarController,

// Close the app menu.

[appMenuController cancel];

EXPECT_FALSE([appMenuController isMenuOpen]) << error_message;

- base::MessageLoop::current()->PostTask(FROM_HERE, closure);

+ base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, closure);

}

// Tests the layout of the overflow container in the app menu.