Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2128193004: Update FilterEffect colorspace on color-interpolation-filters changes (Closed)

Created:
4 years, 5 months ago by fs
Modified:
4 years, 5 months ago
Reviewers:
pdr., Stephen Chennney
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update FilterEffect colorspace on color-interpolation-filters changes Changes to the 'color-interpolation-filters' property would not get propagated to any built (cached) filter chains, and hence any future paints would still use the old chain. Add support for updating this FilterEffect property down in the filter primitive element base-class setFilterEffectAttribute, and then make sure any derived classes forward to it. BUG=625732 Committed: https://crrev.com/6f4665b05795e9170a3af87aec13663f992cc525 Cr-Commit-Position: refs/heads/master@{#404200}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -30 lines) Patch
A third_party/WebKit/LayoutTests/svg/filters/color-interpolation-filters-style-update.html View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/filters/color-interpolation-filters-style-update-expected.html View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilterPrimitive.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEBlendElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEColorMatrixElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFECompositeElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEConvolveMatrixElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEDisplacementMapElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEDropShadowElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEFloodElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEMorphologyElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFESpecularLightingElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFETurbulenceElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp View 2 chunks +10 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.h View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
fs
A big pile of plumbing for what's essentially a single bit... =)
4 years, 5 months ago (2016-07-07 15:28:20 UTC) #2
Stephen Chennney
lgtm In theory we should have a test for every filter type, but in practice ...
4 years, 5 months ago (2016-07-07 17:08:54 UTC) #3
fs
On 2016/07/07 at 17:08:54, schenney wrote: > lgtm > > In theory we should have ...
4 years, 5 months ago (2016-07-07 18:11:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2128193004/1
4 years, 5 months ago (2016-07-07 18:52:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 19:05:54 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 19:07:15 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f4665b05795e9170a3af87aec13663f992cc525
Cr-Commit-Position: refs/heads/master@{#404200}

Powered by Google App Engine
This is Rietveld 408576698