third_party/WebKit/Source/core/svg/SVGFEDropShadowElement.cpp - Issue 2128193004: Update FilterEffect colorspace on color-interpolation-filters changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGFEDropShadowElement.cpp

Issue 2128193004: Update FilterEffect colorspace on color-interpolation-filters changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGFEDisplacementMapElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGFEFloodElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGFEDropShadowElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGFEDropShadowElement.cpp b/third_party/WebKit/Source/core/svg/SVGFEDropShadowElement.cpp

index 6bf775c8b082db3c93753ee183a9d7aeb136c48c..f1dd4aaa4dedd79fb43024d973b24b4c806d57a5 100644

--- a/third_party/WebKit/Source/core/svg/SVGFEDropShadowElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGFEDropShadowElement.cpp

@@ -73,9 +73,7 @@ bool SVGFEDropShadowElement::setFilterEffectAttribute(FilterEffect* effect, cons

dropShadow->setShadowOpacity(svgStyle.floodOpacity());

return true;

}

- NOTREACHED();

- return false;

+ return SVGFilterPrimitiveStandardAttributes::setFilterEffectAttribute(effect, attrName);

}

void SVGFEDropShadowElement::svgAttributeChanged(const QualifiedName& attrName)