Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGFEBlendElement.cpp

Issue 2128193004: Update FilterEffect colorspace on color-interpolation-filters changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 } 106 }
107 107
108 DEFINE_NODE_FACTORY(SVGFEBlendElement) 108 DEFINE_NODE_FACTORY(SVGFEBlendElement)
109 109
110 bool SVGFEBlendElement::setFilterEffectAttribute(FilterEffect* effect, const Qua lifiedName& attrName) 110 bool SVGFEBlendElement::setFilterEffectAttribute(FilterEffect* effect, const Qua lifiedName& attrName)
111 { 111 {
112 FEBlend* blend = static_cast<FEBlend*>(effect); 112 FEBlend* blend = static_cast<FEBlend*>(effect);
113 if (attrName == SVGNames::modeAttr) 113 if (attrName == SVGNames::modeAttr)
114 return blend->setBlendMode(toWebBlendMode(m_mode->currentValue()->enumVa lue())); 114 return blend->setBlendMode(toWebBlendMode(m_mode->currentValue()->enumVa lue()));
115 115
116 ASSERT_NOT_REACHED(); 116 return SVGFilterPrimitiveStandardAttributes::setFilterEffectAttribute(effect , attrName);
117 return false;
118 } 117 }
119 118
120 void SVGFEBlendElement::svgAttributeChanged(const QualifiedName& attrName) 119 void SVGFEBlendElement::svgAttributeChanged(const QualifiedName& attrName)
121 { 120 {
122 if (attrName == SVGNames::modeAttr) { 121 if (attrName == SVGNames::modeAttr) {
123 SVGElement::InvalidationGuard invalidationGuard(this); 122 SVGElement::InvalidationGuard invalidationGuard(this);
124 primitiveAttributeChanged(attrName); 123 primitiveAttributeChanged(attrName);
125 return; 124 return;
126 } 125 }
127 126
(...skipping 14 matching lines...) Expand all
142 141
143 FilterEffect* effect = FEBlend::create(filter, toWebBlendMode(m_mode->curren tValue()->enumValue())); 142 FilterEffect* effect = FEBlend::create(filter, toWebBlendMode(m_mode->curren tValue()->enumValue()));
144 FilterEffectVector& inputEffects = effect->inputEffects(); 143 FilterEffectVector& inputEffects = effect->inputEffects();
145 inputEffects.reserveCapacity(2); 144 inputEffects.reserveCapacity(2);
146 inputEffects.append(input1); 145 inputEffects.append(input1);
147 inputEffects.append(input2); 146 inputEffects.append(input2);
148 return effect; 147 return effect;
149 } 148 }
150 149
151 } // namespace blink 150 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698