third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp - Issue 2128193004: Update FilterEffect colorspace on color-interpolation-filters changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp

Issue 2128193004: Update FilterEffect colorspace on color-interpolation-filters changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGFEConvolveMatrixElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGFEDisplacementMapElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp b/third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp

index f148e7c084f18f0fe66aaaa94da593a7a87eb196..e83d6514924d606c024d16f7f4a2a3c311fb3027 100644

--- a/third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp

@@ -86,8 +86,7 @@ bool SVGFEDiffuseLightingElement::setFilterEffectAttribute(FilterEffect* effect,

if (attrName == SVGNames::limitingConeAngleAttr)

return lightSource->setLimitingConeAngle(lightElement->limitingConeAngle()->currentValue()->value());

- ASSERT_NOT_REACHED();

- return false;

+ return SVGFilterPrimitiveStandardAttributes::setFilterEffectAttribute(effect, attrName);

}

void SVGFEDiffuseLightingElement::svgAttributeChanged(const QualifiedName& attrName)