third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilterPrimitive.cpp - Issue 2128193004: Update FilterEffect colorspace on color-interpolation-filters changes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilterPrimitive.cpp

Issue 2128193004: Update FilterEffect colorspace on color-interpolation-filters changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/filters/color-interpolation-filters-style-update-expected.html ('k') | third_party/WebKit/Source/core/svg/SVGFEBlendElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010 University of Szeged	2 * Copyright (C) 2010 University of Szeged

3 * Copyright (C) 2010 Zoltan Herczeg	3 * Copyright (C) 2010 Zoltan Herczeg

4 * Copyright (C) 2011 Renata Hodovan (reni@webkit.org)	4 * Copyright (C) 2011 Renata Hodovan (reni@webkit.org)

5 *	5 *

6 * Redistribution and use in source and binary forms, with or without	6 * Redistribution and use in source and binary forms, with or without

7 * modification, are permitted provided that the following conditions	7 * modification, are permitted provided that the following conditions

8 * are met:	8 * are met:

9 * 1. Redistributions of source code must retain the above copyright	9 * 1. Redistributions of source code must retain the above copyright

10 * notice, this list of conditions and the following disclaimer.	10 * notice, this list of conditions and the following disclaimer.

(...skipping 32 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
43 DCHECK(element());	43 DCHECK(element());

44 if (isSVGFEFloodElement(element()) \|\| isSVGFEDropShadowElement(element())) {	44 if (isSVGFEFloodElement(element()) \|\| isSVGFEDropShadowElement(element())) {

45 if (newStyle.floodColor() != oldStyle->svgStyle().floodColor())	45 if (newStyle.floodColor() != oldStyle->svgStyle().floodColor())

46 toLayoutSVGResourceFilter(filter)->primitiveAttributeChanged(this, S VGNames::flood_colorAttr);	46 toLayoutSVGResourceFilter(filter)->primitiveAttributeChanged(this, S VGNames::flood_colorAttr);

47 if (newStyle.floodOpacity() != oldStyle->svgStyle().floodOpacity())	47 if (newStyle.floodOpacity() != oldStyle->svgStyle().floodOpacity())

48 toLayoutSVGResourceFilter(filter)->primitiveAttributeChanged(this, S VGNames::flood_opacityAttr);	48 toLayoutSVGResourceFilter(filter)->primitiveAttributeChanged(this, S VGNames::flood_opacityAttr);

49 } else if (isSVGFEDiffuseLightingElement(element()) \|\| isSVGFESpecularLight ingElement(element())) {	49 } else if (isSVGFEDiffuseLightingElement(element()) \|\| isSVGFESpecularLight ingElement(element())) {

50 if (newStyle.lightingColor() != oldStyle->svgStyle().lightingColor())	50 if (newStyle.lightingColor() != oldStyle->svgStyle().lightingColor())

51 toLayoutSVGResourceFilter(filter)->primitiveAttributeChanged(this, S VGNames::lighting_colorAttr);	51 toLayoutSVGResourceFilter(filter)->primitiveAttributeChanged(this, S VGNames::lighting_colorAttr);

52 }	52 }

	53 if (newStyle.colorInterpolationFilters() != oldStyle->svgStyle().colorInterp olationFilters())

	54 toLayoutSVGResourceFilter(filter)->primitiveAttributeChanged(this, SVGNa mes::color_interpolation_filtersAttr);

53 }	55 }

54	56

55 } // namespace blink	57 } // namespace blink

OLD	NEW