[runtime] Better encapsulation of dictionary objects handling in lookup iterator.

[runtime] Better encapsulation of dictionary objects handling in lookup iterator.

Now LookupIterator follows the same pattern of prepare transition, apply transition
and write value when adding new properties to dictionary objects.

JSGlobalObject case:
* Prepare transition phase ensures that there is a "transition" property cell
  prepared for receiving a value.
* Apply transition phase does nothing.
* Prepare for data property phase ensures that the existing property cell can
  receive the value.
* Write value phase writes value directly to the current property cell.

JSObject case:
* Prepare transition phase prepares the object for receiving a data value (which
  could switch an object to dictionary mode).
* Apply transition phase migrates object to a transition map. If the map happened
  to be a dictionary mode object's map then an uninitialized entry added to the
  properties dictionary.
* Prepare for data property phase does nothing.
* Write value phase just puts value to the properties dictionary.

BUG=chromium:576312
Committed: https://crrev.com/3fbb45216de0397a0213db67c7481c586d379b73
Cr-Commit-Position: refs/heads/master@{#37585}

[Igor Sheludko, 2016-07-05 13:45:26]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2016-07-05 13:52:28]

Patchset #1 (id:20001) has been deleted

[Igor Sheludko, 2016-07-05 13:52:36]

Patchset #1 (id:40001) has been deleted

[Igor Sheludko, 2016-07-05 13:52:59]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-05 13:53:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-07-05 13:59:31]

ishell@chromium.org changed reviewers:
+ verwaest@chromium.org

[Igor Sheludko, 2016-07-05 13:59:32]

PTAL

[commit-bot: I haz the power, 2016-07-05 14:12:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-05 14:13:00]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Igor Sheludko, 2016-07-06 10:35:00]

Description was changed from

==========
[runtime] Better encapsulation of dictionary objects handling in lookup
iterator.

Now LookupIterator follows the same pattern of prepare transition, apply
transition
and write value when adding new properties to dictionary objects.

JSGlobalObject case:
* Prepare transition phase ensures that there is a "transition" property cell
  prepared for receiving a value.
* Apply transition phase does nothing.
* Write value phase writes value directly to the "transition" cell.

JSObject case:
* Prepare transition phase prepares the object for receiving a data value (which
  could switch an object to dictionary mode).
* Apply transition phase migrates object to a transition map. If the map
happened
  to be a dictionary mode object's map then an uninitialized entry added to the
  properties dictionary.
* Write value phase just puts value to the properties dictionary.

BUG=chromium:576312
==========

to

==========
[runtime] Better encapsulation of dictionary objects handling in lookup
iterator.

Now LookupIterator follows the same pattern of prepare transition, apply
transition
and write value when adding new properties to dictionary objects.

JSGlobalObject case:
* Prepare transition phase ensures that there is a "transition" property cell
  prepared for receiving a value.
* Apply transition phase does nothing.
* Prepare for data property phase ensures that the existing property cell can
  receive the value.
* Write value phase writes value directly to the current property cell.

JSObject case:
* Prepare transition phase prepares the object for receiving a data value (which
  could switch an object to dictionary mode).
* Apply transition phase migrates object to a transition map. If the map
happened
  to be a dictionary mode object's map then an uninitialized entry added to the
  properties dictionary.
* Prepare for data property phase does nothing.
* Write value phase just puts value to the properties dictionary.

BUG=chromium:576312
==========

[Igor Sheludko, 2016-07-06 10:47:54]

Patchset #2 (id:80001) has been deleted

[Igor Sheludko, 2016-07-06 10:55:01]

Patchset #2 (id:100001) has been deleted

[Igor Sheludko, 2016-07-06 10:56:39]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-06 10:56:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 11:21:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 11:21:44]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2016-07-07 11:10:31]

lgtm. I'm not sure you really need the hasProperty_ = true assignments, but it
probably doesn't matter much.

[Igor Sheludko, 2016-07-07 11:54:57]

On 2016/07/07 11:10:31, Toon Verwaest wrote:
> lgtm. I'm not sure you really need the hasProperty_ = true assignments, but it
> probably doesn't matter much.

We do need them because we are not going to ReloadPropertyInformation() for
JSGlobalObject
and dictionary_entry() requires hasProperty_ to be set.

[Igor Sheludko, 2016-07-07 11:55:05]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2016-07-07 11:55:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 12:32:19]

Description was changed from

==========
[runtime] Better encapsulation of dictionary objects handling in lookup
iterator.

Now LookupIterator follows the same pattern of prepare transition, apply
transition
and write value when adding new properties to dictionary objects.

JSGlobalObject case:
* Prepare transition phase ensures that there is a "transition" property cell
  prepared for receiving a value.
* Apply transition phase does nothing.
* Prepare for data property phase ensures that the existing property cell can
  receive the value.
* Write value phase writes value directly to the current property cell.

JSObject case:
* Prepare transition phase prepares the object for receiving a data value (which
  could switch an object to dictionary mode).
* Apply transition phase migrates object to a transition map. If the map
happened
  to be a dictionary mode object's map then an uninitialized entry added to the
  properties dictionary.
* Prepare for data property phase does nothing.
* Write value phase just puts value to the properties dictionary.

BUG=chromium:576312
==========

to

==========
[runtime] Better encapsulation of dictionary objects handling in lookup
iterator.

Now LookupIterator follows the same pattern of prepare transition, apply
transition
and write value when adding new properties to dictionary objects.

JSGlobalObject case:
* Prepare transition phase ensures that there is a "transition" property cell
  prepared for receiving a value.
* Apply transition phase does nothing.
* Prepare for data property phase ensures that the existing property cell can
  receive the value.
* Write value phase writes value directly to the current property cell.

JSObject case:
* Prepare transition phase prepares the object for receiving a data value (which
  could switch an object to dictionary mode).
* Apply transition phase migrates object to a transition map. If the map
happened
  to be a dictionary mode object's map then an uninitialized entry added to the
  properties dictionary.
* Prepare for data property phase does nothing.
* Write value phase just puts value to the properties dictionary.

BUG=chromium:576312
==========

[commit-bot: I haz the power, 2016-07-07 12:32:20]

Committed patchset #2 (id:120001)

[commit-bot: I haz the power, 2016-07-07 12:32:23]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-07 12:35:13]

Description was changed from

==========
[runtime] Better encapsulation of dictionary objects handling in lookup
iterator.

Now LookupIterator follows the same pattern of prepare transition, apply
transition
and write value when adding new properties to dictionary objects.

JSGlobalObject case:
* Prepare transition phase ensures that there is a "transition" property cell
  prepared for receiving a value.
* Apply transition phase does nothing.
* Prepare for data property phase ensures that the existing property cell can
  receive the value.
* Write value phase writes value directly to the current property cell.

JSObject case:
* Prepare transition phase prepares the object for receiving a data value (which
  could switch an object to dictionary mode).
* Apply transition phase migrates object to a transition map. If the map
happened
  to be a dictionary mode object's map then an uninitialized entry added to the
  properties dictionary.
* Prepare for data property phase does nothing.
* Write value phase just puts value to the properties dictionary.

BUG=chromium:576312
==========

to

==========
[runtime] Better encapsulation of dictionary objects handling in lookup
iterator.

Now LookupIterator follows the same pattern of prepare transition, apply
transition
and write value when adding new properties to dictionary objects.

JSGlobalObject case:
* Prepare transition phase ensures that there is a "transition" property cell
  prepared for receiving a value.
* Apply transition phase does nothing.
* Prepare for data property phase ensures that the existing property cell can
  receive the value.
* Write value phase writes value directly to the current property cell.

JSObject case:
* Prepare transition phase prepares the object for receiving a data value (which
  could switch an object to dictionary mode).
* Apply transition phase migrates object to a transition map. If the map
happened
  to be a dictionary mode object's map then an uninitialized entry added to the
  properties dictionary.
* Prepare for data property phase does nothing.
* Write value phase just puts value to the properties dictionary.

BUG=chromium:576312

Committed: https://crrev.com/3fbb45216de0397a0213db67c7481c586d379b73
Cr-Commit-Position: refs/heads/master@{#37585}
==========

[commit-bot: I haz the power, 2016-07-07 12:35:15]

Patchset 2 (id:??) landed as
https://crrev.com/3fbb45216de0397a0213db67c7481c586d379b73
Cr-Commit-Position: refs/heads/master@{#37585}