Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Unified Diff: src/property-details.h

Issue 2127583002: [runtime] Better encapsulation of dictionary objects handling in lookup iterator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fixes Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects-printer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/property-details.h
diff --git a/src/property-details.h b/src/property-details.h
index e30d6681aaa0cb59adff90fedba93a5a5e580214..87df02d08e3b6ac6c07d7e4efec3e42b6c8ae0c7 100644
--- a/src/property-details.h
+++ b/src/property-details.h
@@ -209,7 +209,6 @@ static const int kMaxNumberOfDescriptors =
static const int kInvalidEnumCacheSentinel =
(1 << kDescriptorIndexBitCount) - 1;
-
enum class PropertyCellType {
// Meaningful when a property cell does not contain the hole.
kUndefined, // The PREMONOMORPHIC of property cells.
@@ -219,13 +218,13 @@ enum class PropertyCellType {
// Meaningful when a property cell contains the hole.
kUninitialized = kUndefined, // Cell has never been initialized.
- kInvalidated = kConstant, // Cell has been deleted or invalidated.
+ kInvalidated = kConstant, // Cell has been deleted, invalidated or never
+ // existed.
// For dictionaries not holding cells.
kNoCell = kMutable,
};
-
enum class PropertyCellConstantType {
kSmi,
kStableMap,
@@ -265,8 +264,9 @@ class PropertyDetails BASE_EMBEDDED {
FieldIndexField::encode(field_index);
}
- static PropertyDetails Empty() {
- return PropertyDetails(NONE, DATA, 0, PropertyCellType::kNoCell);
+ static PropertyDetails Empty(
+ PropertyCellType cell_type = PropertyCellType::kNoCell) {
+ return PropertyDetails(NONE, DATA, 0, cell_type);
}
int pointer() const { return DescriptorPointer::decode(value_); }
« no previous file with comments | « src/objects-printer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698