Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: src/ic/s390/handler-compiler-s390.cc

Issue 2127583002: [runtime] Better encapsulation of dictionary objects handling in lookup iterator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fixes Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/ppc/handler-compiler-ppc.cc ('k') | src/ic/x64/handler-compiler-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_S390 5 #if V8_TARGET_ARCH_S390
6 6
7 #include "src/ic/handler-compiler.h" 7 #include "src/ic/handler-compiler.h"
8 8
9 #include "src/api-arguments.h" 9 #include "src/api-arguments.h"
10 #include "src/field-type.h" 10 #include "src/field-type.h"
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
180 __ LoadRR(r2, scratch1); 180 __ LoadRR(r2, scratch1);
181 __ Ret(); 181 __ Ret();
182 } 182 }
183 183
184 // Generate code to check that a global property cell is empty. Create 184 // Generate code to check that a global property cell is empty. Create
185 // the property cell at compilation time if no cell exists for the 185 // the property cell at compilation time if no cell exists for the
186 // property. 186 // property.
187 void PropertyHandlerCompiler::GenerateCheckPropertyCell( 187 void PropertyHandlerCompiler::GenerateCheckPropertyCell(
188 MacroAssembler* masm, Handle<JSGlobalObject> global, Handle<Name> name, 188 MacroAssembler* masm, Handle<JSGlobalObject> global, Handle<Name> name,
189 Register scratch, Label* miss) { 189 Register scratch, Label* miss) {
190 Handle<PropertyCell> cell = JSGlobalObject::EnsurePropertyCell(global, name); 190 Handle<PropertyCell> cell = JSGlobalObject::EnsureEmptyPropertyCell(
191 global, name, PropertyCellType::kInvalidated);
191 Isolate* isolate = masm->isolate(); 192 Isolate* isolate = masm->isolate();
192 DCHECK(cell->value()->IsTheHole(isolate)); 193 DCHECK(cell->value()->IsTheHole(isolate));
193 Handle<WeakCell> weak_cell = isolate->factory()->NewWeakCell(cell); 194 Handle<WeakCell> weak_cell = isolate->factory()->NewWeakCell(cell);
194 __ LoadWeakValue(scratch, weak_cell, miss); 195 __ LoadWeakValue(scratch, weak_cell, miss);
195 __ LoadP(scratch, FieldMemOperand(scratch, PropertyCell::kValueOffset)); 196 __ LoadP(scratch, FieldMemOperand(scratch, PropertyCell::kValueOffset));
196 __ CompareRoot(scratch, Heap::kTheHoleValueRootIndex); 197 __ CompareRoot(scratch, Heap::kTheHoleValueRootIndex);
197 __ bne(miss); 198 __ bne(miss);
198 } 199 }
199 200
200 static void PushInterceptorArguments(MacroAssembler* masm, Register receiver, 201 static void PushInterceptorArguments(MacroAssembler* masm, Register receiver,
(...skipping 461 matching lines...) Expand 10 before | Expand all | Expand 10 after
662 663
663 // Return the generated code. 664 // Return the generated code.
664 return GetCode(kind(), name); 665 return GetCode(kind(), name);
665 } 666 }
666 667
667 #undef __ 668 #undef __
668 } // namespace internal 669 } // namespace internal
669 } // namespace v8 670 } // namespace v8
670 671
671 #endif // V8_TARGET_ARCH_ARM 672 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/ic/ppc/handler-compiler-ppc.cc ('k') | src/ic/x64/handler-compiler-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698