Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Side by Side Diff: src/ic/x64/handler-compiler-x64.cc

Issue 2127583002: [runtime] Better encapsulation of dictionary objects handling in lookup iterator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fixes Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/s390/handler-compiler-s390.cc ('k') | src/ic/x87/handler-compiler-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X64 5 #if V8_TARGET_ARCH_X64
6 6
7 #include "src/ic/handler-compiler.h" 7 #include "src/ic/handler-compiler.h"
8 8
9 #include "src/api-arguments.h" 9 #include "src/api-arguments.h"
10 #include "src/field-type.h" 10 #include "src/field-type.h"
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 // Jump to stub. 212 // Jump to stub.
213 CallApiCallbackStub stub(isolate, is_store, call_data_undefined, 213 CallApiCallbackStub stub(isolate, is_store, call_data_undefined,
214 !optimization.is_constant_call()); 214 !optimization.is_constant_call());
215 __ TailCallStub(&stub); 215 __ TailCallStub(&stub);
216 } 216 }
217 217
218 218
219 void PropertyHandlerCompiler::GenerateCheckPropertyCell( 219 void PropertyHandlerCompiler::GenerateCheckPropertyCell(
220 MacroAssembler* masm, Handle<JSGlobalObject> global, Handle<Name> name, 220 MacroAssembler* masm, Handle<JSGlobalObject> global, Handle<Name> name,
221 Register scratch, Label* miss) { 221 Register scratch, Label* miss) {
222 Handle<PropertyCell> cell = JSGlobalObject::EnsurePropertyCell(global, name); 222 Handle<PropertyCell> cell = JSGlobalObject::EnsureEmptyPropertyCell(
223 global, name, PropertyCellType::kInvalidated);
223 Isolate* isolate = masm->isolate(); 224 Isolate* isolate = masm->isolate();
224 DCHECK(cell->value()->IsTheHole(isolate)); 225 DCHECK(cell->value()->IsTheHole(isolate));
225 Handle<WeakCell> weak_cell = isolate->factory()->NewWeakCell(cell); 226 Handle<WeakCell> weak_cell = isolate->factory()->NewWeakCell(cell);
226 __ LoadWeakValue(scratch, weak_cell, miss); 227 __ LoadWeakValue(scratch, weak_cell, miss);
227 __ Cmp(FieldOperand(scratch, PropertyCell::kValueOffset), 228 __ Cmp(FieldOperand(scratch, PropertyCell::kValueOffset),
228 isolate->factory()->the_hole_value()); 229 isolate->factory()->the_hole_value());
229 __ j(not_equal, miss); 230 __ j(not_equal, miss);
230 } 231 }
231 232
232 233
(...skipping 483 matching lines...) Expand 10 before | Expand all | Expand 10 after
716 // Return the generated code. 717 // Return the generated code.
717 return GetCode(kind(), name); 718 return GetCode(kind(), name);
718 } 719 }
719 720
720 721
721 #undef __ 722 #undef __
722 } // namespace internal 723 } // namespace internal
723 } // namespace v8 724 } // namespace v8
724 725
725 #endif // V8_TARGET_ARCH_X64 726 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/ic/s390/handler-compiler-s390.cc ('k') | src/ic/x87/handler-compiler-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698