[ic] Initialize feedback slots for LoadGlobalIC in Runtime::kDeclareGlobals when possible to ...

[ic] Initialize feedback slots for LoadGlobalIC in Runtime::kDeclareGlobals when possible to avoid misses.

BUG=chromium:576312
Committed: https://crrev.com/b9a7b28163d0e5b86e2d750109b897654057197a
Cr-Commit-Position: refs/heads/master@{#37709}

[Igor Sheludko, 2016-06-29 16:21:55]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2016-06-29 16:22:06]

Patchset #1 (id:20001) has been deleted

[Igor Sheludko, 2016-06-29 16:24:54]

ishell@chromium.org changed reviewers:
+ verwaest@chromium.org

[Igor Sheludko, 2016-06-29 16:24:55]

PTAL

[Igor Sheludko, 2016-06-29 16:25:02]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-29 16:25:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 16:29:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 16:29:01]

Dry run: Try jobs failed on following builders:
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/4183)

[Igor Sheludko, 2016-06-29 17:00:22]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-29 17:00:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-06-29 17:02:01]

Description was changed from

==========
[ic] Preinitialize feedback slots for LoadGlobalIC in Runtime::kDeclareGlobals
if possible.

BUG=chromium:576312
==========

to

==========
[ic] Initialize feedback slots for LoadGlobalIC in Runtime::kDeclareGlobals if
possible to avoid misses.

BUG=chromium:576312
==========

[commit-bot: I haz the power, 2016-06-29 17:24:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 17:24:44]

Dry run: Try jobs failed on following builders:
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_arm_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng_trigger...)

[Igor Sheludko, 2016-06-30 11:10:26]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-30 11:10:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-06-30 11:34:06]

Description was changed from

==========
[ic] Initialize feedback slots for LoadGlobalIC in Runtime::kDeclareGlobals if
possible to avoid misses.

BUG=chromium:576312
==========

to

==========
[ic] Initialize feedback slots for LoadGlobalIC in Runtime::kDeclareGlobals when
possible to avoid misses.

BUG=chromium:576312
==========

[commit-bot: I haz the power, 2016-06-30 11:59:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 11:59:08]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2016-06-30 15:04:47]

It would be nice to make AddSlowProperty with nicer with the LookupIterator
first. We probably should make it follow the same pattern of prepare transition,
apply transition, write value (possibly omitting the second).

[Igor Sheludko, 2016-07-05 14:08:20]

Patchset #4 (id:100001) has been deleted

[Igor Sheludko, 2016-07-05 14:08:51]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-05 14:08:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 14:28:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-05 14:28:50]

Dry run: Try jobs failed on following builders:
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_nodcheck_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng_tr...)

[Igor Sheludko, 2016-07-06 10:58:14]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-06 10:58:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 11:26:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 11:26:51]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2016-07-13 11:07:19]

lgtm

[Igor Sheludko, 2016-07-13 11:08:06]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2016-07-13 11:08:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 11:12:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 11:12:20]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/19326)

[Benedikt Meurer, 2016-07-13 11:16:59]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2016-07-13 11:17:00]

LGTM on compiler.

[rmcilroy, 2016-07-13 11:19:30]

LGTM on interpreter.

[Igor Sheludko, 2016-07-13 11:20:15]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2016-07-13 11:20:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 11:32:41]

Description was changed from

==========
[ic] Initialize feedback slots for LoadGlobalIC in Runtime::kDeclareGlobals when
possible to avoid misses.

BUG=chromium:576312
==========

to

==========
[ic] Initialize feedback slots for LoadGlobalIC in Runtime::kDeclareGlobals when
possible to avoid misses.

BUG=chromium:576312
==========

[commit-bot: I haz the power, 2016-07-13 11:32:42]

Committed patchset #5 (id:140001)

[commit-bot: I haz the power, 2016-07-13 11:34:35]

Description was changed from

==========
[ic] Initialize feedback slots for LoadGlobalIC in Runtime::kDeclareGlobals when
possible to avoid misses.

BUG=chromium:576312
==========

to

==========
[ic] Initialize feedback slots for LoadGlobalIC in Runtime::kDeclareGlobals when
possible to avoid misses.

BUG=chromium:576312

Committed: https://crrev.com/b9a7b28163d0e5b86e2d750109b897654057197a
Cr-Commit-Position: refs/heads/master@{#37709}
==========

[commit-bot: I haz the power, 2016-07-13 11:34:36]

Patchset 5 (id:??) landed as
https://crrev.com/b9a7b28163d0e5b86e2d750109b897654057197a
Cr-Commit-Position: refs/heads/master@{#37709}