Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Unified Diff: src/objects-printer.cc

Issue 2127583002: [runtime] Better encapsulation of dictionary objects handling in lookup iterator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fixes Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | src/property-details.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-printer.cc
diff --git a/src/objects-printer.cc b/src/objects-printer.cc
index 2c718fae8dbbca0ca0570f671e781f5e2fc732b0..2aed5a0430b075ae318d253f1aeb8107f28e0112 100644
--- a/src/objects-printer.cc
+++ b/src/objects-printer.cc
@@ -995,6 +995,46 @@ void PropertyCell::PropertyCellPrint(std::ostream& os) { // NOLINT
HeapObject::PrintHeader(os, "PropertyCell");
os << "\n - value: " << Brief(value());
os << "\n - details: " << property_details();
+ PropertyCellType cell_type = property_details().cell_type();
+ os << "\n - cell_type: ";
+ if (value()->IsTheHole(GetIsolate())) {
+ switch (cell_type) {
+ case PropertyCellType::kUninitialized:
+ os << "Uninitialized";
+ break;
+ case PropertyCellType::kInvalidated:
+ os << "Invalidated";
+ break;
+ default:
+ os << "??? " << static_cast<int>(cell_type);
+ break;
+ }
+ } else {
+ switch (cell_type) {
+ case PropertyCellType::kUndefined:
+ os << "Undefined";
+ break;
+ case PropertyCellType::kConstant:
+ os << "Constant";
+ break;
+ case PropertyCellType::kConstantType:
+ os << "ConstantType"
+ << " (";
+ switch (GetConstantType()) {
+ case PropertyCellConstantType::kSmi:
+ os << "Smi";
+ break;
+ case PropertyCellConstantType::kStableMap:
+ os << "StableMap";
+ break;
+ }
+ os << ")";
+ break;
+ case PropertyCellType::kMutable:
+ os << "Mutable";
+ break;
+ }
+ }
os << "\n";
}
« no previous file with comments | « src/objects.cc ('k') | src/property-details.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698