Record metrics for permission prompt acceptance vs. user gesture.

chrome/browser/permissions/permission_request_manager_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/histogram_tester.h"
 #include "chrome/browser/permissions/mock_permission_request.h"
 #include "chrome/browser/permissions/permission_request.h"
 #include "chrome/browser/permissions/permission_request_manager.h"
 #include "chrome/browser/permissions/permission_uma_util.h"
 #include "chrome/browser/ui/website_settings/mock_permission_bubble_factory.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 class PermissionRequestManagerTest : public ChromeRenderViewHostTestHarness {
  public:
   PermissionRequestManagerTest()
       : ChromeRenderViewHostTestHarness(),
-        request1_("test1", PermissionRequestType::QUOTA),
-        request2_("test2", PermissionRequestType::DOWNLOAD),
+        request1_("test1",
+                  PermissionRequestType::QUOTA,
+                  PermissionRequestGestureType::GESTURE),
+        request2_("test2",
+                  PermissionRequestType::DOWNLOAD,
+                  PermissionRequestGestureType::NO_GESTURE),
         iframe_request_same_domain_("iframe",
                                     GURL("http://www.google.com/some/url")),
-        iframe_request_other_domain_("iframe",
-                                     GURL("http://www.youtube.com")) {}
+        iframe_request_other_domain_("iframe", GURL("http://www.youtube.com")) {
+  }
   ~PermissionRequestManagerTest() override {}
 
   void SetUp() override {
     ChromeRenderViewHostTestHarness::SetUp();
     SetContents(CreateTestWebContents());
     NavigateAndCommit(GURL("http://www.google.com"));
 
     manager_.reset(new PermissionRequestManager(web_contents()));
     view_factory_.reset(new MockPermissionBubbleFactory(manager_.get()));
   }
@@ skipping 406 matching lines @@
   WaitForFrameLoad();
   WaitForCoalescing();
   manager_->AddRequest(&request1_);
   manager_->AddRequest(&iframe_request_other_domain_);
   manager_->AddRequest(&request2_);
   base::RunLoop().RunUntilIdle();
 
   EXPECT_TRUE(view_factory_->is_visible());
 }
 
-TEST_F(PermissionRequestManagerTest, UMAForSimpleAcceptedBubble) {
+TEST_F(PermissionRequestManagerTest, UMAForSimpleAcceptedGestureBubble) {
   base::HistogramTester histograms;
 
   manager_->AddRequest(&request1_);
   manager_->DisplayPendingRequests();
   WaitForCoalescing();
   histograms.ExpectUniqueSample(
       PermissionUmaUtil::kPermissionsPromptShown,
       static_cast<base::HistogramBase::Sample>(PermissionRequestType::QUOTA),
       1);
   histograms.ExpectUniqueSample(
+      PermissionUmaUtil::kPermissionsPromptShownGesture,
+      static_cast<base::HistogramBase::Sample>(PermissionRequestType::QUOTA),
+      1);
+  histograms.ExpectTotalCount(
+      PermissionUmaUtil::kPermissionsPromptShownNoGesture, 0);
+  histograms.ExpectUniqueSample(
       PermissionUmaUtil::kPermissionsPromptRequestsPerPrompt, 1, 1);
 
   ToggleAccept(0, true);
   Accept();
   histograms.ExpectUniqueSample(
       PermissionUmaUtil::kPermissionsPromptAccepted,
       static_cast<base::HistogramBase::Sample>(PermissionRequestType::QUOTA),
       1);
+  histograms.ExpectTotalCount(
+      PermissionUmaUtil::kPermissionsPromptDenied, 0);
+
+  histograms.ExpectUniqueSample(
+      PermissionUmaUtil::kPermissionsPromptAcceptedGesture,
+      static_cast<base::HistogramBase::Sample>(PermissionRequestType::QUOTA),
+      1);
+  histograms.ExpectTotalCount(
+      PermissionUmaUtil::kPermissionsPromptAcceptedNoGesture, 0);
 }
 
-TEST_F(PermissionRequestManagerTest, UMAForSimpleDeniedBubble) {
+TEST_F(PermissionRequestManagerTest, UMAForSimpleDeniedNoGestureBubble) {
   base::HistogramTester histograms;
 
-  manager_->AddRequest(&request1_);
+  manager_->AddRequest(&request2_);
   manager_->DisplayPendingRequests();
   WaitForCoalescing();
-  // No need to test UMA for showing prompts again, they were tested in
-  // UMAForSimpleAcceptedBubble.
+
+  histograms.ExpectTotalCount(
+      PermissionUmaUtil::kPermissionsPromptShownGesture, 0);
+  histograms.ExpectUniqueSample(
+      PermissionUmaUtil::kPermissionsPromptShownNoGesture,
+      static_cast<base::HistogramBase::Sample>(PermissionRequestType::DOWNLOAD),
+      1);
+  // No need to test the other UMA for showing prompts again, they were tested
+  // in UMAForSimpleAcceptedBubble.
 
   Deny();
+  histograms.ExpectTotalCount(
+      PermissionUmaUtil::kPermissionsPromptAccepted, 0);
   histograms.ExpectUniqueSample(
       PermissionUmaUtil::kPermissionsPromptDenied,
-      static_cast<base::HistogramBase::Sample>(PermissionRequestType::QUOTA),
+      static_cast<base::HistogramBase::Sample>(PermissionRequestType::DOWNLOAD),
       1);
+
+  histograms.ExpectUniqueSample(
+      PermissionUmaUtil::kPermissionsPromptDeniedNoGesture,
+      static_cast<base::HistogramBase::Sample>(PermissionRequestType::DOWNLOAD),
+      1);
+  histograms.ExpectTotalCount(
+      PermissionUmaUtil::kPermissionsPromptDeniedGesture, 0);
 }
 
 // This code path (calling Accept on a non-merged bubble, with no accepted
 // permission) would never be used in actual Chrome, but its still tested for
 // completeness.
 TEST_F(PermissionRequestManagerTest, UMAForSimpleDeniedBubbleAlternatePath) {
   base::HistogramTester histograms;
 
   manager_->AddRequest(&request1_);
   manager_->DisplayPendingRequests();
@@ skipping 24 matching lines @@
   histograms.ExpectBucketCount(
       PermissionUmaUtil::kPermissionsPromptMergedBubbleTypes,
       static_cast<base::HistogramBase::Sample>(PermissionRequestType::QUOTA),
       1);
   histograms.ExpectBucketCount(
       PermissionUmaUtil::kPermissionsPromptMergedBubbleTypes,
       static_cast<base::HistogramBase::Sample>(PermissionRequestType::DOWNLOAD),
       1);
   histograms.ExpectUniqueSample(
       PermissionUmaUtil::kPermissionsPromptRequestsPerPrompt, 2, 1);
+  histograms.ExpectTotalCount(
+      PermissionUmaUtil::kPermissionsPromptShownGesture, 0);
+  histograms.ExpectTotalCount(
+      PermissionUmaUtil::kPermissionsPromptShownNoGesture, 0);
 
   ToggleAccept(0, true);
   ToggleAccept(1, true);
   Accept();
 
   histograms.ExpectUniqueSample(
       PermissionUmaUtil::kPermissionsPromptAccepted,
       static_cast<base::HistogramBase::Sample>(PermissionRequestType::MULTIPLE),
       1);
   histograms.ExpectBucketCount(
@@ skipping 54 matching lines @@
       1);
   histograms.ExpectBucketCount(
       PermissionUmaUtil::kPermissionsPromptMergedBubbleDenied,
       static_cast<base::HistogramBase::Sample>(PermissionRequestType::QUOTA),
       1);
   histograms.ExpectBucketCount(
       PermissionUmaUtil::kPermissionsPromptMergedBubbleDenied,
       static_cast<base::HistogramBase::Sample>(PermissionRequestType::DOWNLOAD),
       1);
 }