Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6754)

Unified Diff: chrome/browser/permissions/permission_request_impl.cc

Issue 2124703002: Record metrics for permission prompt acceptance vs. user gesture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: wups Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_request_impl.cc
diff --git a/chrome/browser/permissions/permission_request_impl.cc b/chrome/browser/permissions/permission_request_impl.cc
index c7b226998c70b85c7ef211594a00565bafc968fb..da4c6495591fac42213fc2797c1b0314537e6d2b 100644
--- a/chrome/browser/permissions/permission_request_impl.cc
+++ b/chrome/browser/permissions/permission_request_impl.cc
@@ -18,11 +18,13 @@ PermissionRequestImpl::PermissionRequestImpl(
const GURL& request_origin,
content::PermissionType permission_type,
Profile* profile,
+ bool has_gesture,
const PermissionDecidedCallback& permission_decided_callback,
const base::Closure delete_callback)
: request_origin_(request_origin),
permission_type_(permission_type),
profile_(profile),
+ has_gesture_(has_gesture),
permission_decided_callback_(permission_decided_callback),
delete_callback_(delete_callback),
is_finished_(false),
@@ -158,3 +160,9 @@ PermissionRequestType PermissionRequestImpl::GetPermissionRequestType()
return PermissionRequestType::UNKNOWN;
}
}
+
+PermissionRequestGestureType PermissionRequestImpl::GetGestureType()
+ const {
+ return has_gesture_ ? PermissionRequestGestureType::GESTURE
+ : PermissionRequestGestureType::NO_GESTURE;
+}

Powered by Google App Engine
This is Rietveld 408576698