Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: chrome/browser/permissions/mock_permission_request.cc

Issue 2124703002: Record metrics for permission prompt acceptance vs. user gesture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: wups Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/mock_permission_request.cc
diff --git a/chrome/browser/permissions/mock_permission_request.cc b/chrome/browser/permissions/mock_permission_request.cc
index be7dd48e7ac4487f06691b744aba4053de4f6b81..dc172243b9f4d4eebf25091f885c9fa943456cbf 100644
--- a/chrome/browser/permissions/mock_permission_request.cc
+++ b/chrome/browser/permissions/mock_permission_request.cc
@@ -10,45 +10,52 @@
MockPermissionRequest::MockPermissionRequest()
: MockPermissionRequest("test",
- "button",
- "button",
- GURL("http://www.google.com"),
- PermissionRequestType::UNKNOWN) {}
+ "button",
+ "button",
+ GURL("http://www.google.com"),
+ PermissionRequestType::UNKNOWN,
+ PermissionRequestGestureType::UNKNOWN) {}
MockPermissionRequest::MockPermissionRequest(
const std::string& text)
: MockPermissionRequest(text,
- "button",
- "button",
- GURL("http://www.google.com"),
- PermissionRequestType::UNKNOWN) {}
+ "button",
+ "button",
+ GURL("http://www.google.com"),
+ PermissionRequestType::UNKNOWN,
+ PermissionRequestGestureType::UNKNOWN) {}
MockPermissionRequest::MockPermissionRequest(
- const std::string& text, PermissionRequestType request_type)
+ const std::string& text,
+ PermissionRequestType request_type,
+ PermissionRequestGestureType gesture_type)
: MockPermissionRequest(text,
- "button",
- "button",
- GURL("http://www.google.com"),
- request_type) {}
+ "button",
+ "button",
+ GURL("http://www.google.com"),
+ request_type,
+ gesture_type) {}
MockPermissionRequest::MockPermissionRequest(
const std::string& text,
const GURL& url)
: MockPermissionRequest(text,
- "button",
- "button",
- url,
- PermissionRequestType::UNKNOWN) {}
+ "button",
+ "button",
+ url,
+ PermissionRequestType::UNKNOWN,
+ PermissionRequestGestureType::UNKNOWN) {}
MockPermissionRequest::MockPermissionRequest(
const std::string& text,
const std::string& accept_label,
const std::string& deny_label)
: MockPermissionRequest(text,
- accept_label,
- deny_label,
- GURL("http://www.google.com"),
- PermissionRequestType::UNKNOWN) {}
+ accept_label,
+ deny_label,
+ GURL("http://www.google.com"),
+ PermissionRequestType::UNKNOWN,
+ PermissionRequestGestureType::UNKNOWN) {}
MockPermissionRequest::~MockPermissionRequest() {}
@@ -87,6 +94,11 @@ PermissionRequestType MockPermissionRequest::GetPermissionRequestType()
return request_type_;
}
+PermissionRequestGestureType MockPermissionRequest::GetGestureType()
+ const {
+ return gesture_type_;
+}
+
bool MockPermissionRequest::granted() {
return granted_;
}
@@ -104,11 +116,13 @@ MockPermissionRequest::MockPermissionRequest(
const std::string& accept_label,
const std::string& deny_label,
const GURL& origin,
- PermissionRequestType request_type)
+ PermissionRequestType request_type,
+ PermissionRequestGestureType gesture_type)
: granted_(false),
cancelled_(false),
finished_(false),
- request_type_(request_type) {
+ request_type_(request_type),
+ gesture_type_(gesture_type) {
text_ = base::UTF8ToUTF16(text);
accept_label_ = base::UTF8ToUTF16(accept_label);
deny_label_ = base::UTF8ToUTF16(deny_label);
« no previous file with comments | « chrome/browser/permissions/mock_permission_request.h ('k') | chrome/browser/permissions/permission_context_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698