chrome/browser/permissions/permission_context_base.cc - Issue 2124703002: Record metrics for permission prompt acceptance vs. user gesture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_context_base.cc

Issue 2124703002: Record metrics for permission prompt acceptance vs. user gesture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: wups Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/permissions/permission_context_base.cc

diff --git a/chrome/browser/permissions/permission_context_base.cc b/chrome/browser/permissions/permission_context_base.cc

index 873b2bea3d8de3b0f49c5c9a925af4eb0905e237..f0fc52cbb09308d88950e6bfdf851895201c2cd0 100644

--- a/chrome/browser/permissions/permission_context_base.cc

+++ b/chrome/browser/permissions/permission_context_base.cc

@@ -177,7 +177,7 @@ void PermissionContextBase::DecidePermission(

if (!permission_request_manager)

return;

std::unique_ptr<PermissionRequest> request_ptr(new PermissionRequestImpl(

- requesting_origin, permission_type_, profile_,

+ requesting_origin, permission_type_, profile_, user_gesture,

base::Bind(&PermissionContextBase::PermissionDecided,

weak_factory_.GetWeakPtr(), id, requesting_origin,

embedding_origin, callback),

« no previous file with comments | « chrome/browser/permissions/mock_permission_request.cc ('k') | chrome/browser/permissions/permission_request.h » ('j') | no next file with comments »