Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: chrome/browser/permissions/permission_request_impl.h

Issue 2124703002: Record metrics for permission prompt acceptance vs. user gesture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: wups Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_request_impl.h
diff --git a/chrome/browser/permissions/permission_request_impl.h b/chrome/browser/permissions/permission_request_impl.h
index 5b4d34c998e9c1e99daab5f2768466b26cb05df6..333f04efb18693918fe66e6f13f563b54f29082d 100644
--- a/chrome/browser/permissions/permission_request_impl.h
+++ b/chrome/browser/permissions/permission_request_impl.h
@@ -27,6 +27,7 @@ class PermissionRequestImpl : public PermissionRequest {
const GURL& request_origin,
content::PermissionType permission_type,
Profile* profile,
+ bool has_gesture,
const PermissionDecidedCallback& permission_decided_callback,
const base::Closure delete_callback);
@@ -48,10 +49,12 @@ class PermissionRequestImpl : public PermissionRequest {
void Cancelled() override;
void RequestFinished() override;
PermissionRequestType GetPermissionRequestType() const override;
+ PermissionRequestGestureType GetGestureType() const override;
GURL request_origin_;
content::PermissionType permission_type_;
Profile* profile_;
+ bool has_gesture_;
// Called once a decision is made about the permission.
const PermissionDecidedCallback permission_decided_callback_;
« no previous file with comments | « chrome/browser/permissions/permission_request.cc ('k') | chrome/browser/permissions/permission_request_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698