Revert of Begin instanced rendering for simple shapes

Revert of Begin instanced rendering for simple shapes (patchset #20 id:380001 of https://codereview.chromium.org/2066993003/ )

Reason for revert:
This caused static initializer regressions in Chromium (crbug.com/625728).

Relevant build logs here:
Linux:
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/21849

Mac:
https://build.chromium.org/p/chromium/builders/Mac/builds/17350

Relevant lines from the error log:
Linux:
# InstanceProcessor.cpp GrUniqueKey::GenerateDomain()
# InstanceProcessor.cpp gr_instanced::kShapeBufferDomain
FAILED linux-release-64/sizes/nacl_helper-si/initializers: actual 8, expected 7, better lower
FAILED linux-release-64/sizes/chrome-si/initializers: actual 8, expected 7, better lower

Mac:
FAILED mac-release/sizes/chrome-si/initializers: actual 2, expected 0, better lower


Original issue's description:
> Begin instanced rendering for simple shapes
> 
> Adds a module that performs instanced rendering and starts using it
> for a select subset of draws on Mac GL platforms. The instance
> processor can currently handle rects, ovals, round rects, and double
> round rects. It can generalize shapes as round rects in order to
> improve batching. The instance processor also employs new drawing
> algorithms, irrespective of instanced rendering, that improve GPU-side
> performance (e.g. sample mask, different triangle layouts, etc.).
> 
> This change only scratches the surface of instanced rendering. The
> majority of draws still only have one instance. Future work may
> include:
> 
>  * Passing coord transforms through the texel buffer.
>  * Sending FP uniforms through instanced vertex attribs.
>  * Using instanced rendering for more draws (stencil writes,
>    drawAtlas, etc.).
>  * Adding more shapes to the instance processor’s repertoire.
>  * Batching draws that have mismatched scissors (analyzing draw
>    bounds, inserting clip planes, etc.).
>  * Bindless textures.
>  * Uber shaders.
> 
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2066993003
> 
> Committed: https://skia.googlesource.com/skia/+/42eafa4bc00354b132ad114d22ed6b95d8849891

NOTREECHECKS=true
TBR=bsalomon@google.com,egdaniel@google.com,robertphillips@google.com,csmartdalton@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/ec7f2ac7285ad9b1ea84e7aa68a741ae2a07a777

[Kunihiko Sakamoto, 2016-07-05 04:10:52]

The CQ bit was checked by ksakamoto@chromium.org

[Kunihiko Sakamoto, 2016-07-05 04:10:53]

Created Revert of Begin instanced rendering for simple shapes

[commit-bot: I haz the power, 2016-07-05 04:10:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 04:10:57]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2016-07-05 10:10 UTC

[commit-bot: I haz the power, 2016-07-05 10:10:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-05 10:10:05]

No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer

[rmistry, 2016-07-05 10:49:25]

rmistry@google.com changed reviewers:
+ rmistry@google.com

[rmistry, 2016-07-05 10:49:25]

lgtm

[rmistry, 2016-07-05 10:49:34]

The CQ bit was checked by rmistry@google.com

[commit-bot: I haz the power, 2016-07-05 10:49:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rmistry, 2016-07-05 10:53:26]

Description was changed from

==========
Revert of Begin instanced rendering for simple shapes (patchset #20 id:380001 of
https://codereview.chromium.org/2066993003/ )

Reason for revert:
This caused static initializer regressions in Chromium (crbug.com/625728).

Relevant build logs here:
Linux:
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/21849

Mac:
https://build.chromium.org/p/chromium/builders/Mac/builds/17350

Relevant lines from the error log:
Linux:
# InstanceProcessor.cpp GrUniqueKey::GenerateDomain()
# InstanceProcessor.cpp gr_instanced::kShapeBufferDomain
FAILED linux-release-64/sizes/nacl_helper-si/initializers: actual 8, expected 7,
better lower
FAILED linux-release-64/sizes/chrome-si/initializers: actual 8, expected 7,
better lower

Mac:
FAILED mac-release/sizes/chrome-si/initializers: actual 2, expected 0, better
lower


Original issue's description:
> Begin instanced rendering for simple shapes
> 
> Adds a module that performs instanced rendering and starts using it
> for a select subset of draws on Mac GL platforms. The instance
> processor can currently handle rects, ovals, round rects, and double
> round rects. It can generalize shapes as round rects in order to
> improve batching. The instance processor also employs new drawing
> algorithms, irrespective of instanced rendering, that improve GPU-side
> performance (e.g. sample mask, different triangle layouts, etc.).
> 
> This change only scratches the surface of instanced rendering. The
> majority of draws still only have one instance. Future work may
> include:
> 
>  * Passing coord transforms through the texel buffer.
>  * Sending FP uniforms through instanced vertex attribs.
>  * Using instanced rendering for more draws (stencil writes,
>    drawAtlas, etc.).
>  * Adding more shapes to the instance processor’s repertoire.
>  * Batching draws that have mismatched scissors (analyzing draw
>    bounds, inserting clip planes, etc.).
>  * Bindless textures.
>  * Uber shaders.
> 
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2066993003
> 
> Committed:
https://skia.googlesource.com/skia/+/42eafa4bc00354b132ad114d22ed6b95d8849891

TBR=bsalomon@google.com,egdaniel@google.com,robertphillips@google.com,csmartd...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=skia:
==========

to

==========
Revert of Begin instanced rendering for simple shapes (patchset #20 id:380001 of
https://codereview.chromium.org/2066993003/ )

Reason for revert:
This caused static initializer regressions in Chromium (crbug.com/625728).

Relevant build logs here:
Linux:
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/21849

Mac:
https://build.chromium.org/p/chromium/builders/Mac/builds/17350

Relevant lines from the error log:
Linux:
# InstanceProcessor.cpp GrUniqueKey::GenerateDomain()
# InstanceProcessor.cpp gr_instanced::kShapeBufferDomain
FAILED linux-release-64/sizes/nacl_helper-si/initializers: actual 8, expected 7,
better lower
FAILED linux-release-64/sizes/chrome-si/initializers: actual 8, expected 7,
better lower

Mac:
FAILED mac-release/sizes/chrome-si/initializers: actual 2, expected 0, better
lower


Original issue's description:
> Begin instanced rendering for simple shapes
> 
> Adds a module that performs instanced rendering and starts using it
> for a select subset of draws on Mac GL platforms. The instance
> processor can currently handle rects, ovals, round rects, and double
> round rects. It can generalize shapes as round rects in order to
> improve batching. The instance processor also employs new drawing
> algorithms, irrespective of instanced rendering, that improve GPU-side
> performance (e.g. sample mask, different triangle layouts, etc.).
> 
> This change only scratches the surface of instanced rendering. The
> majority of draws still only have one instance. Future work may
> include:
> 
>  * Passing coord transforms through the texel buffer.
>  * Sending FP uniforms through instanced vertex attribs.
>  * Using instanced rendering for more draws (stencil writes,
>    drawAtlas, etc.).
>  * Adding more shapes to the instance processor’s repertoire.
>  * Batching draws that have mismatched scissors (analyzing draw
>    bounds, inserting clip planes, etc.).
>  * Bindless textures.
>  * Uber shaders.
> 
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2066993003
> 
> Committed:
https://skia.googlesource.com/skia/+/42eafa4bc00354b132ad114d22ed6b95d8849891

NOTREECHECKS=true
TBR=bsalomon@google.com,egdaniel@google.com,robertphillips@google.com,csmartd...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=skia:
==========

[rmistry, 2016-07-05 10:53:33]

The CQ bit was checked by rmistry@google.com

[rmistry, 2016-07-05 10:53:34]

The CQ bit was unchecked by rmistry@google.com

[rmistry, 2016-07-05 10:53:46]

The CQ bit was checked by rmistry@google.com

[commit-bot: I haz the power, 2016-07-05 10:53:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 10:54:57]

Description was changed from

==========
Revert of Begin instanced rendering for simple shapes (patchset #20 id:380001 of
https://codereview.chromium.org/2066993003/ )

Reason for revert:
This caused static initializer regressions in Chromium (crbug.com/625728).

Relevant build logs here:
Linux:
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/21849

Mac:
https://build.chromium.org/p/chromium/builders/Mac/builds/17350

Relevant lines from the error log:
Linux:
# InstanceProcessor.cpp GrUniqueKey::GenerateDomain()
# InstanceProcessor.cpp gr_instanced::kShapeBufferDomain
FAILED linux-release-64/sizes/nacl_helper-si/initializers: actual 8, expected 7,
better lower
FAILED linux-release-64/sizes/chrome-si/initializers: actual 8, expected 7,
better lower

Mac:
FAILED mac-release/sizes/chrome-si/initializers: actual 2, expected 0, better
lower


Original issue's description:
> Begin instanced rendering for simple shapes
> 
> Adds a module that performs instanced rendering and starts using it
> for a select subset of draws on Mac GL platforms. The instance
> processor can currently handle rects, ovals, round rects, and double
> round rects. It can generalize shapes as round rects in order to
> improve batching. The instance processor also employs new drawing
> algorithms, irrespective of instanced rendering, that improve GPU-side
> performance (e.g. sample mask, different triangle layouts, etc.).
> 
> This change only scratches the surface of instanced rendering. The
> majority of draws still only have one instance. Future work may
> include:
> 
>  * Passing coord transforms through the texel buffer.
>  * Sending FP uniforms through instanced vertex attribs.
>  * Using instanced rendering for more draws (stencil writes,
>    drawAtlas, etc.).
>  * Adding more shapes to the instance processor’s repertoire.
>  * Batching draws that have mismatched scissors (analyzing draw
>    bounds, inserting clip planes, etc.).
>  * Bindless textures.
>  * Uber shaders.
> 
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2066993003
> 
> Committed:
https://skia.googlesource.com/skia/+/42eafa4bc00354b132ad114d22ed6b95d8849891

NOTREECHECKS=true
TBR=bsalomon@google.com,egdaniel@google.com,robertphillips@google.com,csmartd...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=skia:
==========

to

==========
Revert of Begin instanced rendering for simple shapes (patchset #20 id:380001 of
https://codereview.chromium.org/2066993003/ )

Reason for revert:
This caused static initializer regressions in Chromium (crbug.com/625728).

Relevant build logs here:
Linux:
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/21849

Mac:
https://build.chromium.org/p/chromium/builders/Mac/builds/17350

Relevant lines from the error log:
Linux:
# InstanceProcessor.cpp GrUniqueKey::GenerateDomain()
# InstanceProcessor.cpp gr_instanced::kShapeBufferDomain
FAILED linux-release-64/sizes/nacl_helper-si/initializers: actual 8, expected 7,
better lower
FAILED linux-release-64/sizes/chrome-si/initializers: actual 8, expected 7,
better lower

Mac:
FAILED mac-release/sizes/chrome-si/initializers: actual 2, expected 0, better
lower


Original issue's description:
> Begin instanced rendering for simple shapes
> 
> Adds a module that performs instanced rendering and starts using it
> for a select subset of draws on Mac GL platforms. The instance
> processor can currently handle rects, ovals, round rects, and double
> round rects. It can generalize shapes as round rects in order to
> improve batching. The instance processor also employs new drawing
> algorithms, irrespective of instanced rendering, that improve GPU-side
> performance (e.g. sample mask, different triangle layouts, etc.).
> 
> This change only scratches the surface of instanced rendering. The
> majority of draws still only have one instance. Future work may
> include:
> 
>  * Passing coord transforms through the texel buffer.
>  * Sending FP uniforms through instanced vertex attribs.
>  * Using instanced rendering for more draws (stencil writes,
>    drawAtlas, etc.).
>  * Adding more shapes to the instance processor’s repertoire.
>  * Batching draws that have mismatched scissors (analyzing draw
>    bounds, inserting clip planes, etc.).
>  * Bindless textures.
>  * Uber shaders.
> 
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2066993003
> 
> Committed:
https://skia.googlesource.com/skia/+/42eafa4bc00354b132ad114d22ed6b95d8849891

NOTREECHECKS=true
TBR=bsalomon@google.com,egdaniel@google.com,robertphillips@google.com,csmartd...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=skia:

Committed:
https://skia.googlesource.com/skia/+/ec7f2ac7285ad9b1ea84e7aa68a741ae2a07a777
==========

[commit-bot: I haz the power, 2016-07-05 10:54:58]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ec7f2ac7285ad9b1ea84e7aa68a741ae2a07a777