Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2120163002: Enable blend optimizations with instanced draws (Closed)

Created:
4 years, 5 months ago by csmartdalton
Modified:
4 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@upload_ingorecov
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Enable blend optimizations with instanced draws Implements InstancedRendering::Batch::computePipelineOptimizations. It was originally believed that blend optimizations could only hurt performance by interfering with batching. But it turns out that: (1) blend optimizations can significantly improve GPU-side performance by avoiding dual source blending and/or dst copies, and (2) blend optimizations can actually *facilitate* batching by allowing opaque src and src_over draws to combine. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2120163002

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixes for perf regressions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3603 lines, -30 lines) Patch
M bench/ShapesBench.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M gyp/gpu.gypi View 1 2 chunks +9 lines, -0 lines 0 comments Download
M include/gpu/GrDrawContext.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
A include/private/GrInstancedPipelineInfo.h View 1 1 chunk +49 lines, -0 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 9 chunks +81 lines, -13 lines 0 comments Download
M src/gpu/GrDrawContextPriv.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 2 chunks +20 lines, -13 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 4 chunks +11 lines, -1 line 0 comments Download
M src/gpu/GrDrawingManager.cpp View 1 3 chunks +14 lines, -0 lines 0 comments Download
M src/gpu/GrGpu.h View 1 3 chunks +10 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 3 chunks +5 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 3 chunks +7 lines, -0 lines 0 comments Download
A src/gpu/instanced/GLInstancedRendering.h View 1 1 chunk +60 lines, -0 lines 0 comments Download
A src/gpu/instanced/GLInstancedRendering.cpp View 1 1 chunk +301 lines, -0 lines 0 comments Download
A src/gpu/instanced/InstanceProcessor.h View 1 1 chunk +63 lines, -0 lines 0 comments Download
A src/gpu/instanced/InstanceProcessor.cpp View 1 1 chunk +2096 lines, -0 lines 0 comments Download
A src/gpu/instanced/InstancedRendering.h View 1 1 chunk +187 lines, -0 lines 0 comments Download
A src/gpu/instanced/InstancedRendering.cpp View 1 1 chunk +488 lines, -0 lines 0 comments Download
A src/gpu/instanced/InstancedRenderingTypes.h View 1 1 chunk +192 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 5 (3 generated)
csmartdalton
https://codereview.chromium.org/2120163002/diff/1/src/gpu/instanced/InstancedRendering.cpp File src/gpu/instanced/InstancedRendering.cpp (left): https://codereview.chromium.org/2120163002/diff/1/src/gpu/instanced/InstancedRendering.cpp#oldcode397 src/gpu/instanced/InstancedRendering.cpp:397: // later combine with a non-rect. This comment was ...
4 years, 5 months ago (2016-07-03 17:36:43 UTC) #3
csmartdalton
4 years, 5 months ago (2016-07-05 23:08:36 UTC) #5
Message was sent while issue was closed.
Rolled into https://codereview.chromium.org/2066993003/

Powered by Google App Engine
This is Rietveld 408576698