Allow origin trials to be declared on IDL operations (methods)

Allow origin trials to be declared on IDL operations (methods)

This change follows the changes to the V8 bindings generation code that allowed
origin trials to be defined on attributes and constants. Similarly, it
refactors the various lists of methods which were being passed into the template
context into a single list and several filters which may be applied to it.

This patch covers only the first stage of method support: Individual methods in
full or partial interfaces, with no overloads. Attempting to define an origin
trial on an overloaded method will result in an exception at compile time.

R=haraken@chromium.org, yukishiino@chromium.org
BUG=621641
Committed: https://crrev.com/81ca9f1a235637fffa49775ecf9d62286297dc95
Cr-Commit-Position: refs/heads/master@{#402799}

[iclelland, 2016-06-29 02:56:45]

haraken, Yuki, can you PTAL? Thanks!

[Yuki, 2016-06-29 03:56:22]

LGTM.

https://codereview.chromium.org/2106983002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp
(right):

https://codereview.chromium.org/2106983002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp:33:
#include "core/origin_trials/OriginTrials.h"
Why do we need OriginTrials.h?
Can we remove this?

[haraken, 2016-06-29 04:05:28]

LGTM

https://codereview.chromium.org/2106983002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/scripts/v8_methods.py (right):

https://codereview.chromium.org/2106983002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/v8_methods.py:105:
'method_for_origin_trial_feature': method_for_origin_trial_feature}

Nit: Alphabetical order.

[iclelland, 2016-06-29 05:04:21]

https://codereview.chromium.org/2106983002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/scripts/v8_methods.py (right):

https://codereview.chromium.org/2106983002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/v8_methods.py:105:
'method_for_origin_trial_feature': method_for_origin_trial_feature}
On 2016/06/29 04:05:28, haraken wrote:
> 
> Nit: Alphabetical order.

Done.

https://codereview.chromium.org/2106983002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp
(right):

https://codereview.chromium.org/2106983002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp:33:
#include "core/origin_trials/OriginTrials.h"
On 2016/06/29 03:56:22, Yuki wrote:
> Why do we need OriginTrials.h?
> Can we remove this?

It turns out we can, and from V8TestInterfaceOriginTrialEnabled.cpp as well -- I
moved the code that inserts the includes into the origin_trial_feature_names
function, so that it can take into account the methods that are actually
implemented, not just those that are defined in the IDL file.

Thanks for pointing that out. Done.

[Yuki, 2016-06-29 05:33:16]

Thanks!  LGTM.

[iclelland, 2016-06-29 13:13:30]

The CQ bit was checked by iclelland@chromium.org

[iclelland, 2016-06-29 13:13:31]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2106983002/#ps40001
(title: "Removing unneeded includes, addressing nits")

[commit-bot: I haz the power, 2016-06-29 13:13:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 14:20:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-29 14:20:07]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-29 14:21:44]

Description was changed from

==========
Allow origin trials to be declared on IDL operations (methods)

This change follows the changes to the V8 bindings generation code that allowed
origin trials to be defined on attributes and constants. Similarly, it
refactors the various lists of methods which were being passed into the template
context into a single list and several filters which may be applied to it.

This patch covers only the first stage of method support: Individual methods in
full or partial interfaces, with no overloads. Attempting to define an origin
trial on an overloaded method will result in an exception at compile time.

R=haraken@chromium.org, yukishiino@chromium.org
BUG=621641
==========

to

==========
Allow origin trials to be declared on IDL operations (methods)

This change follows the changes to the V8 bindings generation code that allowed
origin trials to be defined on attributes and constants. Similarly, it
refactors the various lists of methods which were being passed into the template
context into a single list and several filters which may be applied to it.

This patch covers only the first stage of method support: Individual methods in
full or partial interfaces, with no overloads. Attempting to define an origin
trial on an overloaded method will result in an exception at compile time.

R=haraken@chromium.org, yukishiino@chromium.org
BUG=621641

Committed: https://crrev.com/81ca9f1a235637fffa49775ecf9d62286297dc95
Cr-Commit-Position: refs/heads/master@{#402799}
==========

[commit-bot: I haz the power, 2016-06-29 14:21:45]

Patchset 3 (id:??) landed as
https://crrev.com/81ca9f1a235637fffa49775ecf9d62286297dc95
Cr-Commit-Position: refs/heads/master@{#402799}