Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origin_trials.js

Issue 2106983002: Allow origin trials to be declared on IDL operations (methods) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing unneeded includes, addressing nits Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/scripts/code_generator_v8.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origin_trials.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origin_trials.js b/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origin_trials.js
index 61b456fee7b12a7b7b5a4df60947484ea4224110..a8c49f2b4eaf6c20fe3c0daa33d6213f7f076452 100644
--- a/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origin_trials.js
+++ b/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origin_trials.js
@@ -43,8 +43,6 @@ expect_failure = (t) => {
assert_not_exists(window.internals, 'FROBULATE_CONST_PARTIAL');
assert_equals(window.internals['FROBULATE_CONST_PARTIAL'], undefined);
}
-// TODO(chasej): Uncomment when methods are supported for origin trials bindings (crbug.com/621641)
-/*
}, {
desc: 'Method should not exist on partial interface, with trial disabled',
code: () => {
@@ -52,7 +50,6 @@ expect_failure = (t) => {
assert_not_exists(window.internals, 'frobulateMethodPartial');
assert_equals(window.internals['frobulateMethodPartial'], undefined);
}
-*/
}];
fetch_tests_from_worker(new Worker('resources/disabled-worker.js'));
@@ -99,13 +96,10 @@ test(() => {
assert_equals(window.internals.FROBULATE_CONST_PARTIAL, 2, 'Constant should return integer value');
}, 'Constant should exist on partial interface and return value');
-// TODO(chasej): Uncomment when methods are supported for origin trials bindings (crbug.com/621641)
-/*
test(() => {
assert_idl_attribute(window.internals, 'frobulateMethodPartial');
assert_true(window.internals.frobulateMethodPartial(), 'Method should return boolean value');
}, 'Method should exist on partial interface and return value');
-*/
fetch_tests_from_worker(new Worker('resources/enabled-worker.js'));
};
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/scripts/code_generator_v8.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698