third_party/WebKit/Source/bindings/templates/interface.cpp - Issue 2106983002: Allow origin trials to be declared on IDL operations (methods)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/interface.cpp

Issue 2106983002: Allow origin trials to be declared on IDL operations (methods) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removing unneeded includes, addressing nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/interface.h ('k') | third_party/WebKit/Source/bindings/templates/interface_base.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/interface.cpp

diff --git a/third_party/WebKit/Source/bindings/templates/interface.cpp b/third_party/WebKit/Source/bindings/templates/interface.cpp

index 1cde31a67b8086833d54e332cd16cafcaecce144..32c4425ee774be86596a0345a6a36094281c12ef 100644

--- a/third_party/WebKit/Source/bindings/templates/interface.cpp

+++ b/third_party/WebKit/Source/bindings/templates/interface.cpp

@@ -870,7 +870,7 @@ void {{v8_class}}::installConditionallyEnabledProperties(v8::Local<v8::Object> i

{##############################################################################}

{% block prepare_prototype_and_interface_object %}

{% from 'methods.cpp' import install_conditionally_enabled_methods with context %}

-{% if unscopeables or has_conditional_attributes_on_prototype or conditionally_enabled_methods %}

+{% if unscopeables or has_conditional_attributes_on_prototype or methods | conditionally_exposed(is_partial) %}

void {{v8_class}}::preparePrototypeAndInterfaceObject(v8::Local<v8::Context> context, const DOMWrapperWorld& world, v8::Local<v8::Object> prototypeObject, v8::Local<v8::Function> interfaceObject, v8::Local<v8::FunctionTemplate> interfaceTemplate)

{

v8::Isolate* isolate = context->GetIsolate();

@@ -880,7 +880,7 @@ void {{v8_class}}::preparePrototypeAndInterfaceObject(v8::Local<v8::Context> con

{% if has_conditional_attributes_on_prototype %}

{{install_conditionally_enabled_attributes_on_prototype() | indent}}

{% endif %}

-{% if conditionally_enabled_methods %}

+{% if methods | conditionally_exposed(is_partial) %}

{% endif %}

}