third_party/WebKit/Source/bindings/templates/methods.cpp - Issue 2106983002: Allow origin trials to be declared on IDL operations (methods)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/methods.cpp

Issue 2106983002: Allow origin trials to be declared on IDL operations (methods) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removing unneeded includes, addressing nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/interface_base.cpp ('k') | third_party/WebKit/Source/bindings/templates/partial_interface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/methods.cpp

diff --git a/third_party/WebKit/Source/bindings/templates/methods.cpp b/third_party/WebKit/Source/bindings/templates/methods.cpp

index 8c4d11b7d51df16f2eb77769d2c827bdf5688f34..7da229e550055d6fe6ba1edcd669ed0be57fdff7 100644

--- a/third_party/WebKit/Source/bindings/templates/methods.cpp

+++ b/third_party/WebKit/Source/bindings/templates/methods.cpp

@@ -671,12 +671,12 @@ V8DOMConfiguration::installMethod(isolate, world, {{instance_template}}, {{proto

{######################################}

{% macro install_conditionally_enabled_methods() %}

-{% if conditionally_enabled_methods %}

+{% if methods | conditionally_exposed(is_partial) %}

{# Define operations with limited exposure #}

v8::Local<v8::Signature> signature = v8::Signature::New(isolate, interfaceTemplate);

ExecutionContext* executionContext = toExecutionContext(prototypeObject->CreationContext());

ASSERT(executionContext);

-{% for method in conditionally_enabled_methods %}

+{% for method in methods | conditionally_exposed(is_partial) %}

{% filter exposed(method.overloads.exposed_test_all

if method.overloads else

method.exposed_test) %}