third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl - Issue 2106983002: Allow origin trials to be declared on IDL operations (methods)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl

Issue 2106983002: Allow origin trials to be declared on IDL operations (methods) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removing unneeded includes, addressing nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/partial_interface.cpp ('k') | third_party/WebKit/Source/bindings/tests/idls/modules/TestInterfacePartial4.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl

diff --git a/third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl b/third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl

index ca128f4019c8df264a11fa6ab9d1bf90a41ba87a..f18ae1f53e1e8dd356294605f2be36604a6f3ec7 100644

--- a/third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl

+++ b/third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl

@@ -546,10 +546,10 @@ interface TestObject {

[DeprecateAs=TestFeatureA, MeasureAs=TestFeatureB] void deprecateAsSameValueMeasureAsSameValueOverloadedMethod();

[DeprecateAs=TestFeatureA, MeasureAs=TestFeatureB] void deprecateAsSameValueMeasureAsSameValueOverloadedMethod(long arg);

[NotEnumerable] void notEnumerableVoidMethod();

- // TODO(iclelland): Re-enable origin trials on individual methods

+ [OriginTrialEnabled=FeatureName] void originTrialEnabledVoidMethod();

+ [PerWorldBindings, OriginTrialEnabled=FeatureName] void perWorldBindingsOriginTrialEnabledVoidMethod();

+ // TODO(iclelland): Re-enable origin trials on overloaded methods

// (crbug.com/621641)

- // [OriginTrialEnabled=FeatureName] void originTrialEnabledVoidMethod();

- // [PerWorldBindings, OriginTrialEnabled=FeatureName] void perWorldBindingsOriginTrialEnabledVoidMethod();

// [OriginTrialEnabled=FeatureName] void originTrialEnabledOverloadedVoidMethod(DOMString stringArg);

// [OriginTrialEnabled=FeatureName] void originTrialEnabledOverloadedVoidMethod(long longArg);

// [OriginTrialEnabled=FeatureName1] void partiallyOriginTrialEnabledOverloadedVoidMethod(DOMString stringArg);