Allow origin trials to be declared on IDL operations (methods)

third_party/WebKit/Source/bindings/templates/interface_base.cpp

 {% include 'copyright_block.txt' %}
 #include "{{v8_class_or_partial}}.h"
 
 {% for filename in cpp_includes if filename != '%s.h' % cpp_class_or_partial %}
 #include "{{filename}}"
 {% endfor %}
 
 namespace blink {
 {% set to_active_scriptwrappable = '%s::toActiveScriptWrappable' % v8_class
                                    if active_scriptwrappable else '0' %}
@@ skipping 200 matching lines @@
     {% for attribute in attributes | has_accessor_configuration %}
     {{attribute_configuration(attribute)}},
     {% endfor %}
 };
 
 {% endif %}
 {% endblock %}
 {##############################################################################}
 {% block install_methods %}
 {% from 'methods.cpp' import method_configuration with context %}
-{% if method_configuration_methods %}
+{% if methods | has_method_configuration(is_partial) %}
 const V8DOMConfiguration::MethodConfiguration {{v8_class}}Methods[] = {
-    {% for method in method_configuration_methods %}
+    {% for method in methods | has_method_configuration(is_partial) %}
     {{method_configuration(method)}},
     {% endfor %}
 };
 
 {% endif %}
 {% endblock %}
 {% endif %}{# not is_array_buffer_or_view #}
 {##############################################################################}
 {% block named_constructor %}{% endblock %}
 {% block constructor_callback %}{% endblock %}
 {##############################################################################}
 {% block install_dom_template %}
 {% if not is_array_buffer_or_view %}
 {% from 'methods.cpp' import install_custom_signature with context %}
 {% from 'attributes.cpp' import attribute_configuration with context %}
 {% from 'constants.cpp' import install_constants with context %}
+{% from 'methods.cpp' import method_configuration with context %}
 {% if has_partial_interface or is_partial %}
 void {{v8_class_or_partial}}::install{{v8_class}}Template(v8::Isolate* isolate, const DOMWrapperWorld& world, v8::Local<v8::FunctionTemplate> interfaceTemplate)
 {% else %}
 static void install{{v8_class}}Template(v8::Isolate* isolate, const DOMWrapperWorld& world, v8::Local<v8::FunctionTemplate> interfaceTemplate)
 {% endif %}
 {
     {% set newline = '' %}
     // Initialize the interface object's template.
     {% if is_partial %}
     {{v8_class}}::install{{v8_class}}Template(isolate, world, interfaceTemplate);
@@ skipping 25 matching lines @@
     {% filter runtime_enabled(runtime_enabled_function) %}
     {% if constants %}
     {{install_constants() | indent}}
     {% endif %}
     {% if attributes | has_attribute_configuration %}
     V8DOMConfiguration::installAttributes(isolate, world, instanceTemplate, prototypeTemplate, {{'%sAttributes' % v8_class}}, {{'WTF_ARRAY_LENGTH(%sAttributes)' % v8_class}});
     {% endif %}
     {% if attributes | has_accessor_configuration %}
     V8DOMConfiguration::installAccessors(isolate, world, instanceTemplate, prototypeTemplate, interfaceTemplate, signature, {{'%sAccessors' % v8_class}}, {{'WTF_ARRAY_LENGTH(%sAccessors)' % v8_class}});
     {% endif %}
-    {% if method_configuration_methods %}
+    {% if methods | has_method_configuration(is_partial) %}
     V8DOMConfiguration::installMethods(isolate, world, instanceTemplate, prototypeTemplate, interfaceTemplate, signature, {{'%sMethods' % v8_class}}, {{'WTF_ARRAY_LENGTH(%sMethods)' % v8_class}});
     {% endif %}
     {% endfilter %}
     {%- if has_access_check_callbacks and not is_partial %}{{newline}}
     // Cross-origin access check
     instanceTemplate->SetAccessCheckCallback({{cpp_class}}V8Internal::securityCheck, v8::External::New(isolate, const_cast<WrapperTypeInfo*>(&{{v8_class}}::wrapperTypeInfo)));
     {% endif %}
 
     {%- if has_array_iterator and not is_partial and not is_global %}{{newline}}
     // Array iterator
@@ skipping 37 matching lines @@
 
     {%- if has_custom_legacy_call_as_function and not is_partial %}{{newline}}
     instanceTemplate->SetCallAsFunctionHandler({{v8_class}}::legacyCallCustom);
     {% endif %}
 
     {%- if interface_name == 'HTMLAllCollection' and not is_partial %}{{newline}}
     // Needed for legacy support of document.all
     instanceTemplate->MarkAsUndetectable();
     {% endif %}
 
-    {%- if custom_registration_methods %}{{newline}}
-    {% for method in custom_registration_methods %}
+    {%- if methods | custom_registration(is_partial) %}{{newline}}
+    {% for method in methods | custom_registration(is_partial) %}
     {# install_custom_signature #}
     {% filter exposed(method.overloads.exposed_test_all
                       if method.overloads else
                       method.exposed_test) %}
     {% filter runtime_enabled(method.overloads.runtime_enabled_function_all
                               if method.overloads else
                               method.runtime_enabled_function) %}
     {% if method.is_do_not_check_security %}
     {{install_do_not_check_security_method(method, '', 'instanceTemplate', 'prototypeTemplate') | indent}}
     {% else %}
     {{install_custom_signature(method, 'instanceTemplate', 'prototypeTemplate', 'interfaceTemplate', 'signature') | indent}}
     {% endif %}
     {% endfilter %}
     {% endfilter %}
     {% endfor %}
     {% endif %}
 }
 
 {% endif %}{# not is_array_buffer_or_view #}
 {% endblock %}
 {##############################################################################}
 {% block origin_trials %}
 {% from 'attributes.cpp' import attribute_configuration with context %}
 {% from 'constants.cpp' import constant_configuration with context %}
+{% from 'methods.cpp' import method_configuration with context %}
 {% for origin_trial_feature_name in origin_trial_feature_names %}{{newline}}
 void {{v8_class_or_partial}}::install{{origin_trial_feature_name}}(ScriptState* scriptState, v8::Local<v8::Object> instance)
 {
     v8::Local<v8::Object> prototype = instance->GetPrototype()->ToObject(scriptState->isolate());
+
     {# Origin-Trial-enabled attributes #}
-    {% if attributes | for_origin_trial_feature(origin_trial_feature_name) %}
+    {% if attributes | for_origin_trial_feature(origin_trial_feature_name) or
+          methods | method_for_origin_trial_feature(origin_trial_feature_name, is_partial) %}
     V8PerIsolateData* perIsolateData = V8PerIsolateData::from(scriptState->isolate());
     v8::Local<v8::FunctionTemplate> interfaceTemplate = perIsolateData->findInterfaceTemplate(scriptState->world(), &{{v8_class}}::wrapperTypeInfo);
     v8::Local<v8::Signature> signature = v8::Signature::New(scriptState->isolate(), interfaceTemplate);
     ALLOW_UNUSED_LOCAL(signature);
+    {% endif %}
+    {% if constants | for_origin_trial_feature(origin_trial_feature_name) or
+          methods | method_for_origin_trial_feature(origin_trial_feature_name, is_partial) %}
+    V8PerContextData* perContextData = V8PerContextData::from(scriptState->context());
+    v8::Local<v8::Function> interface = perContextData->constructorForType(&{{v8_class}}::wrapperTypeInfo);
+    {% endif %}
     {% for attribute in attributes | for_origin_trial_feature(origin_trial_feature_name) | unique_by('name') | sort %}
     {% if attribute.is_data_type_property %}
     const V8DOMConfiguration::AttributeConfiguration attribute{{attribute.name}}Configuration = \
         {{attribute_configuration(attribute)}};
     V8DOMConfiguration::installAttribute(scriptState->isolate(), scriptState->world(), instance, prototype, attribute{{attribute.name}}Configuration);
     {% else %}
     const V8DOMConfiguration::AccessorConfiguration accessor{{attribute.name}}Configuration = \
         {{attribute_configuration(attribute)}};
     V8DOMConfiguration::installAccessor(scriptState->isolate(), scriptState->world(), instance, prototype, v8::Local<v8::Function>(), signature, accessor{{attribute.name}}Configuration);
     {% endif %}
     {% endfor %}
-    {% endif %}
-
     {# Origin-Trial-enabled constants #}
-    {% if constants | for_origin_trial_feature(origin_trial_feature_name) %}
-    V8PerContextData* perContextData = V8PerContextData::from(scriptState->context());
-    v8::Local<v8::Function> interface = perContextData->constructorForType(&{{v8_class}}::wrapperTypeInfo);
     {% for constant in constants | for_origin_trial_feature(origin_trial_feature_name) | unique_by('name') | sort %}
     {% set constant_name = constant.name.title().replace('_', '') %}
     const V8DOMConfiguration::ConstantConfiguration constant{{constant_name}}Configuration = {{constant_configuration(constant)}};
     V8DOMConfiguration::installConstant(scriptState->isolate(), interface, prototype, constant{{constant_name}}Configuration);
     {% endfor %}
-    {% endif %}
+    {# Origin-Trial-enabled methods (no overloads) #}
+    {% for method in methods | method_for_origin_trial_feature(origin_trial_feature_name, is_partial) | unique_by('name') | sort %}
+    {% set method_name = method.name.title().replace('_', '') %}
+    const V8DOMConfiguration::MethodConfiguration method{{method_name}}Configuration = {{method_configuration(method)}};
+    V8DOMConfiguration::installMethod(scriptState->isolate(), scriptState->world(), instance, prototype, interface, signature, method{{method_name}}Configuration);
+    {% endfor %}
 }
 {% endfor %}
 {% endblock %}
 {##############################################################################}
 {% block get_dom_template %}{% endblock %}
 {% block get_dom_template_for_named_properties_object %}{% endblock %}
 {% block has_instance %}{% endblock %}
 {% block to_impl %}{% endblock %}
 {% block to_impl_with_type_check %}{% endblock %}
 {% block install_conditional_attributes %}{% endblock %}
 {##############################################################################}
 {% block prepare_prototype_and_interface_object %}{% endblock %}
 {##############################################################################}
 {% block to_active_scriptwrappable %}{% endblock %}
 {% for method in methods if method.is_implemented_in_private_script and method.visible %}
 {{method_implemented_in_private_script(method)}}
 {% endfor %}
 {% for attribute in attributes if attribute.is_implemented_in_private_script %}
 {{attribute_getter_implemented_in_private_script(attribute)}}
 {% if attribute.has_setter %}
 {{attribute_setter_implemented_in_private_script(attribute)}}
 {% endif %}
 {% endfor %}
 {% block partial_interface %}{% endblock %}
 } // namespace blink