Landing recent QUIC changes until 6/24/2016 14:00 UTC

Landing recent QUIC changes until 6/24/2016 14:00 UTC

Change QuicBufferedPacketStore to store QuicReceivedPackets instead of QuicEncrypterPackets, since that is what the Dispatcher uses. Also to take a const clock. Add a method for checking if packets are buffered for a connection ID.

Also clang-format these files since they appear to be incorrectly
styled.

Merge internal change: 125777729
https://codereview.chromium.org/2099313003

Stop using next_packet_sequence_number_length in QuicPacketCreator.  No functional change.  Protected by FLAGS_quic_simple_packet_number_length.

Merge internal change: 125727775
https://codereview.chromium.org2101623003

Add QuicConnectionCloseDelegateInterface. No functional change expected. Not protected.

Merge internal change: 125703498
https://codereview.chromium.org/2099403002

Replace QUIC's PathMtuAckListener with a non-AckListener approach. Protected by FLAGS_quic_no_mtu_discovery_ack_listener.

Merge internal change: 125678921
https://codereview.chromium.org/2100763003

Change users of NextPacketNumberLength to GetPacketNumberLength in QuicPacketCreatorTest when GetPacketNumberLength is equivalent or better.

Merge internal change: 125674835
https://codereview.chromium.org/2104503003

Remove two tests from QuicConnectionTest because they were duplicates of those in QuicPacketCreatorTest.

Merge internal change: 125640116
http://crrev.com/2102713002

Deprecate FLAGS_quic_detect_memory_corrpution.

Merge internal change: 125572214
https://codereview.chromium.org/2107473002

Deprecate FLAGS_quic_disallow_multi_packet_chlo.

Merge internal change: 125572148
https://codereview.chromium.org/2102733002

Add extra logging when QuicFramer's AppendStopWaiting fails to serialize.

Merge internal change: 125563155
https://codereview.chromium.org/2102723002

Add functionality to explicitly set SNI in the QUIC test client

The QUIC test client currently sets SNI based on the request URL which
triggers the client to connect.  This is problematic for tests which
want to set the SNI to something else (in this
case: SSL compartments tests).  This change makes it possible for such
tests to explicitly override this setting.

Merge internal change: 125561343
https://codereview.chromium.org/2101003002

Deleting blank lines from argument list of HandshakeWithFakeClient

Merge internal change: 125459408
https://codereview.chromium.org/2099123003

Let QUIC respect HTTP2 Settings frame. Currently, only SETTINGS_HEADER_TABLE_SIZE is supported. Protected by FLAGS_quic_respect_http2_settings_frame, default true.

Merge internal change: 125448073
https://codereview.chromium.org/2102703002]

Make QuicSpdyStream::ParseHeaderStatusCode() inparam const.

No functional change.

* Use SpdyHeaderBlock::find() instead of operator[] so that |header| is
  not
  modified.
* Make |header| const (and pass by reference instead of pointer).
* Eliminate SpdyHeaderBlock copy in
  QuicSimpleServerStream::SendResponse().

Merge internal change: 125445090
https://codereview.chromium.org/2100213002

Add a new kMIDS (Max Incoming Dynamic Streams) config option, to eventually replace kMSPC.

Adds QUIC_VERSION_35 which allows endpoints to independently set max
open streams. Protected by FLAGS_quic_enable_version_35

Merge internal change: 125773608
https://codereview.chromium.org/2101353003

Flip recent QUIC flags.
https://codereview.chromium.org/2107943002/

Committed: https://crrev.com/ca37822cd5ec99b6b652dec25b6a99aed1dcaa59
Cr-Commit-Position: refs/heads/master@{#402669}

[Ryan Hamilton, 2016-06-27 22:36:20]

rch@chromium.org changed reviewers:
+ rtenneti@chromium.org

[Ryan Hamilton, 2016-06-27 22:36:41]

Patchset #4 (id:60001) has been deleted

[Ryan Hamilton, 2016-06-27 22:36:50]

The CQ bit was checked by rch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 22:37:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ramant (doing other things), 2016-06-27 22:39:52]

lgtm

[commit-bot: I haz the power, 2016-06-27 23:07:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 23:07:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ryan Hamilton, 2016-06-28 21:06:54]

Description was changed from

==========
Landing recent QUIC changes until 6/24/2016 14:00 UTC

Change QuicBufferedPacketStore to store QuicReceivedPackets instead of
QuicEncrypterPackets, since that is what the Dispatcher uses. Also to take a
const clock. Add a method for checking if packets are buffered for a connection
ID.

Also clang-format these files since they appear to be incorrectly
styled.

Merge internal change: 125777729
http://crrev.com/2099313003


Stop using next_packet_sequence_number_length in QuicPacketCreator.  No
functional change.  Protected by FLAGS_quic_simple_packet_number_length.

Merge internal change: 125727775
http://crrev.com/2101623003


Add QuicConnectionCloseDelegateInterface. No functional change expected. Not
protected.

Merge internal change: 125703498
http://crrev.com/2099403002


Replace QUIC's PathMtuAckListener with a non-AckListener approach. Protected by
FLAGS_quic_no_mtu_discovery_ack_listener.

Merge internal change: 125678921
http://crrev.com/2100763003


Change users of NextPacketNumberLength to GetPacketNumberLength in
QuicPacketCreatorTest when GetPacketNumberLength is equivalent or better.

Merge internal change: 125674835
http://crrev.com/2104503003


Remove two tests from QuicConnectionTest because they were duplicates of those
in QuicPacketCreatorTest.

Merge internal change: 125640116
http://crrev.com/2102713002


Deprecate FLAGS_quic_detect_memory_corrpution.

Merge internal change: 125572214
http://crrev.com/2107473002


Deprecate FLAGS_quic_disallow_multi_packet_chlo.

Merge internal change: 125572148
http://crrev.com/2102733002


Add extra logging when QuicFramer's AppendStopWaiting fails to serialize.

Merge internal change: 125563155
http://crrev.com/2102723002


Add functionality to explicitly set SNI in the QUIC test client

The QUIC test client currently sets SNI based on the request URL which
triggers the client to connect.  This is problematic for tests which
want to set the SNI to something else (in this
case: SSL compartments tests).  This change makes it possible for such
tests to explicitly override this setting.

Merge internal change: 125561343
http://crrev.com/2101003002

Deleting blank lines from argument list of HandshakeWithFakeClient

Merge internal change: 125459408
http://crrev.com/2099123003


Let QUIC respect HTTP2 Settings frame. Currently, only
SETTINGS_HEADER_TABLE_SIZE is supported. Protected by
FLAGS_quic_respect_http2_settings_frame, default true.

Merge internal change: 125448073
http://crrev.com/2102703002]

Make QuicSpdyStream::ParseHeaderStatusCode() inparam const.

No functional change.

* Use SpdyHeaderBlock::find() instead of operator[] so that |header| is
  not
  modified.
* Make |header| const (and pass by reference instead of pointer).
* Eliminate SpdyHeaderBlock copy in
  QuicSimpleServerStream::SendResponse().

Merge internal change: 125445090
http://crrev.com/2100213002
==========

to

==========
Landing recent QUIC changes until 6/24/2016 14:00 UTC

Change QuicBufferedPacketStore to store QuicReceivedPackets instead of
QuicEncrypterPackets, since that is what the Dispatcher uses. Also to take a
const clock. Add a method for checking if packets are buffered for a connection
ID.

Also clang-format these files since they appear to be incorrectly
styled.

Merge internal change: 125777729
https://codereview.chromium.org/2099313003


Stop using next_packet_sequence_number_length in QuicPacketCreator.  No
functional change.  Protected by FLAGS_quic_simple_packet_number_length.

Merge internal change: 125727775
https://codereview.chromium.org2101623003


Add QuicConnectionCloseDelegateInterface. No functional change expected. Not
protected.

Merge internal change: 125703498
https://codereview.chromium.org/2099403002


Replace QUIC's PathMtuAckListener with a non-AckListener approach. Protected by
FLAGS_quic_no_mtu_discovery_ack_listener.

Merge internal change: 125678921
https://codereview.chromium.org/2100763003


Change users of NextPacketNumberLength to GetPacketNumberLength in
QuicPacketCreatorTest when GetPacketNumberLength is equivalent or better.

Merge internal change: 125674835
https://codereview.chromium.org/2104503003


Remove two tests from QuicConnectionTest because they were duplicates of those
in QuicPacketCreatorTest.

Merge internal change: 125640116
http://crrev.com/2102713002


Deprecate FLAGS_quic_detect_memory_corrpution.

Merge internal change: 125572214
https://codereview.chromium.org/2107473002


Deprecate FLAGS_quic_disallow_multi_packet_chlo.

Merge internal change: 125572148
https://codereview.chromium.org/2102733002


Add extra logging when QuicFramer's AppendStopWaiting fails to serialize.

Merge internal change: 125563155
https://codereview.chromium.org/2102723002


Add functionality to explicitly set SNI in the QUIC test client

The QUIC test client currently sets SNI based on the request URL which
triggers the client to connect.  This is problematic for tests which
want to set the SNI to something else (in this
case: SSL compartments tests).  This change makes it possible for such
tests to explicitly override this setting.

Merge internal change: 125561343
https://codereview.chromium.org/2101003002


Deleting blank lines from argument list of HandshakeWithFakeClient

Merge internal change: 125459408
https://codereview.chromium.org/2099123003


Let QUIC respect HTTP2 Settings frame. Currently, only
SETTINGS_HEADER_TABLE_SIZE is supported. Protected by
FLAGS_quic_respect_http2_settings_frame, default true.

Merge internal change: 125448073
https://codereview.chromium.org/2102703002]


Make QuicSpdyStream::ParseHeaderStatusCode() inparam const.

No functional change.

* Use SpdyHeaderBlock::find() instead of operator[] so that |header| is
  not
  modified.
* Make |header| const (and pass by reference instead of pointer).
* Eliminate SpdyHeaderBlock copy in
  QuicSimpleServerStream::SendResponse().

Merge internal change: 125445090
https://codereview.chromium.org/2100213002


Flip recent QUIC flags.
https://codereview.chromium.org/2107943002/
==========

[Ryan Hamilton, 2016-06-28 21:35:37]

The CQ bit was checked by rch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-28 21:37:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 21:42:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 21:42:42]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ryan Hamilton, 2016-06-28 21:53:33]

The CQ bit was checked by rch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-28 21:54:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Hamilton, 2016-06-28 22:38:59]

Description was changed from

==========
Landing recent QUIC changes until 6/24/2016 14:00 UTC

Change QuicBufferedPacketStore to store QuicReceivedPackets instead of
QuicEncrypterPackets, since that is what the Dispatcher uses. Also to take a
const clock. Add a method for checking if packets are buffered for a connection
ID.

Also clang-format these files since they appear to be incorrectly
styled.

Merge internal change: 125777729
https://codereview.chromium.org/2099313003


Stop using next_packet_sequence_number_length in QuicPacketCreator.  No
functional change.  Protected by FLAGS_quic_simple_packet_number_length.

Merge internal change: 125727775
https://codereview.chromium.org2101623003


Add QuicConnectionCloseDelegateInterface. No functional change expected. Not
protected.

Merge internal change: 125703498
https://codereview.chromium.org/2099403002


Replace QUIC's PathMtuAckListener with a non-AckListener approach. Protected by
FLAGS_quic_no_mtu_discovery_ack_listener.

Merge internal change: 125678921
https://codereview.chromium.org/2100763003


Change users of NextPacketNumberLength to GetPacketNumberLength in
QuicPacketCreatorTest when GetPacketNumberLength is equivalent or better.

Merge internal change: 125674835
https://codereview.chromium.org/2104503003


Remove two tests from QuicConnectionTest because they were duplicates of those
in QuicPacketCreatorTest.

Merge internal change: 125640116
http://crrev.com/2102713002


Deprecate FLAGS_quic_detect_memory_corrpution.

Merge internal change: 125572214
https://codereview.chromium.org/2107473002


Deprecate FLAGS_quic_disallow_multi_packet_chlo.

Merge internal change: 125572148
https://codereview.chromium.org/2102733002


Add extra logging when QuicFramer's AppendStopWaiting fails to serialize.

Merge internal change: 125563155
https://codereview.chromium.org/2102723002


Add functionality to explicitly set SNI in the QUIC test client

The QUIC test client currently sets SNI based on the request URL which
triggers the client to connect.  This is problematic for tests which
want to set the SNI to something else (in this
case: SSL compartments tests).  This change makes it possible for such
tests to explicitly override this setting.

Merge internal change: 125561343
https://codereview.chromium.org/2101003002


Deleting blank lines from argument list of HandshakeWithFakeClient

Merge internal change: 125459408
https://codereview.chromium.org/2099123003


Let QUIC respect HTTP2 Settings frame. Currently, only
SETTINGS_HEADER_TABLE_SIZE is supported. Protected by
FLAGS_quic_respect_http2_settings_frame, default true.

Merge internal change: 125448073
https://codereview.chromium.org/2102703002]


Make QuicSpdyStream::ParseHeaderStatusCode() inparam const.

No functional change.

* Use SpdyHeaderBlock::find() instead of operator[] so that |header| is
  not
  modified.
* Make |header| const (and pass by reference instead of pointer).
* Eliminate SpdyHeaderBlock copy in
  QuicSimpleServerStream::SendResponse().

Merge internal change: 125445090
https://codereview.chromium.org/2100213002


Flip recent QUIC flags.
https://codereview.chromium.org/2107943002/
==========

to

==========
Landing recent QUIC changes until 6/24/2016 14:00 UTC

Change QuicBufferedPacketStore to store QuicReceivedPackets instead of
QuicEncrypterPackets, since that is what the Dispatcher uses. Also to take a
const clock. Add a method for checking if packets are buffered for a connection
ID.

Also clang-format these files since they appear to be incorrectly
styled.

Merge internal change: 125777729
https://codereview.chromium.org/2099313003


Stop using next_packet_sequence_number_length in QuicPacketCreator.  No
functional change.  Protected by FLAGS_quic_simple_packet_number_length.

Merge internal change: 125727775
https://codereview.chromium.org2101623003


Add QuicConnectionCloseDelegateInterface. No functional change expected. Not
protected.

Merge internal change: 125703498
https://codereview.chromium.org/2099403002


Replace QUIC's PathMtuAckListener with a non-AckListener approach. Protected by
FLAGS_quic_no_mtu_discovery_ack_listener.

Merge internal change: 125678921
https://codereview.chromium.org/2100763003


Change users of NextPacketNumberLength to GetPacketNumberLength in
QuicPacketCreatorTest when GetPacketNumberLength is equivalent or better.

Merge internal change: 125674835
https://codereview.chromium.org/2104503003


Remove two tests from QuicConnectionTest because they were duplicates of those
in QuicPacketCreatorTest.

Merge internal change: 125640116
http://crrev.com/2102713002


Deprecate FLAGS_quic_detect_memory_corrpution.

Merge internal change: 125572214
https://codereview.chromium.org/2107473002


Deprecate FLAGS_quic_disallow_multi_packet_chlo.

Merge internal change: 125572148
https://codereview.chromium.org/2102733002


Add extra logging when QuicFramer's AppendStopWaiting fails to serialize.

Merge internal change: 125563155
https://codereview.chromium.org/2102723002


Add functionality to explicitly set SNI in the QUIC test client

The QUIC test client currently sets SNI based on the request URL which
triggers the client to connect.  This is problematic for tests which
want to set the SNI to something else (in this
case: SSL compartments tests).  This change makes it possible for such
tests to explicitly override this setting.

Merge internal change: 125561343
https://codereview.chromium.org/2101003002


Deleting blank lines from argument list of HandshakeWithFakeClient

Merge internal change: 125459408
https://codereview.chromium.org/2099123003


Let QUIC respect HTTP2 Settings frame. Currently, only
SETTINGS_HEADER_TABLE_SIZE is supported. Protected by
FLAGS_quic_respect_http2_settings_frame, default true.

Merge internal change: 125448073
https://codereview.chromium.org/2102703002]


Make QuicSpdyStream::ParseHeaderStatusCode() inparam const.

No functional change.

* Use SpdyHeaderBlock::find() instead of operator[] so that |header| is
  not
  modified.
* Make |header| const (and pass by reference instead of pointer).
* Eliminate SpdyHeaderBlock copy in
  QuicSimpleServerStream::SendResponse().

Merge internal change: 125445090
https://codereview.chromium.org/2100213002


Add a new kMIDS (Max Incoming Dynamic Streams) config option, to eventually
replace kMSPC.

Adds QUIC_VERSION_35 which allows endpoints to independently set max
open streams. Protected by FLAGS_quic_enable_version_35

Merge internal change: 125773608
https://codereview.chromium.org/2101353003


Flip recent QUIC flags.
https://codereview.chromium.org/2107943002/
==========

[Ryan Hamilton, 2016-06-28 23:15:52]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2016-06-28 23:15:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
rtenneti@chromium.org
Link to the patchset: https://codereview.chromium.org/2104633002/#ps140001
(title: "Rebase")

[commit-bot: I haz the power, 2016-06-28 23:17:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 23:36:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 23:36:21]

Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Ryan Hamilton, 2016-06-29 01:07:24]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2016-06-29 01:09:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 02:23:49]

Description was changed from

==========
Landing recent QUIC changes until 6/24/2016 14:00 UTC

Change QuicBufferedPacketStore to store QuicReceivedPackets instead of
QuicEncrypterPackets, since that is what the Dispatcher uses. Also to take a
const clock. Add a method for checking if packets are buffered for a connection
ID.

Also clang-format these files since they appear to be incorrectly
styled.

Merge internal change: 125777729
https://codereview.chromium.org/2099313003


Stop using next_packet_sequence_number_length in QuicPacketCreator.  No
functional change.  Protected by FLAGS_quic_simple_packet_number_length.

Merge internal change: 125727775
https://codereview.chromium.org2101623003


Add QuicConnectionCloseDelegateInterface. No functional change expected. Not
protected.

Merge internal change: 125703498
https://codereview.chromium.org/2099403002


Replace QUIC's PathMtuAckListener with a non-AckListener approach. Protected by
FLAGS_quic_no_mtu_discovery_ack_listener.

Merge internal change: 125678921
https://codereview.chromium.org/2100763003


Change users of NextPacketNumberLength to GetPacketNumberLength in
QuicPacketCreatorTest when GetPacketNumberLength is equivalent or better.

Merge internal change: 125674835
https://codereview.chromium.org/2104503003


Remove two tests from QuicConnectionTest because they were duplicates of those
in QuicPacketCreatorTest.

Merge internal change: 125640116
http://crrev.com/2102713002


Deprecate FLAGS_quic_detect_memory_corrpution.

Merge internal change: 125572214
https://codereview.chromium.org/2107473002


Deprecate FLAGS_quic_disallow_multi_packet_chlo.

Merge internal change: 125572148
https://codereview.chromium.org/2102733002


Add extra logging when QuicFramer's AppendStopWaiting fails to serialize.

Merge internal change: 125563155
https://codereview.chromium.org/2102723002


Add functionality to explicitly set SNI in the QUIC test client

The QUIC test client currently sets SNI based on the request URL which
triggers the client to connect.  This is problematic for tests which
want to set the SNI to something else (in this
case: SSL compartments tests).  This change makes it possible for such
tests to explicitly override this setting.

Merge internal change: 125561343
https://codereview.chromium.org/2101003002


Deleting blank lines from argument list of HandshakeWithFakeClient

Merge internal change: 125459408
https://codereview.chromium.org/2099123003


Let QUIC respect HTTP2 Settings frame. Currently, only
SETTINGS_HEADER_TABLE_SIZE is supported. Protected by
FLAGS_quic_respect_http2_settings_frame, default true.

Merge internal change: 125448073
https://codereview.chromium.org/2102703002]


Make QuicSpdyStream::ParseHeaderStatusCode() inparam const.

No functional change.

* Use SpdyHeaderBlock::find() instead of operator[] so that |header| is
  not
  modified.
* Make |header| const (and pass by reference instead of pointer).
* Eliminate SpdyHeaderBlock copy in
  QuicSimpleServerStream::SendResponse().

Merge internal change: 125445090
https://codereview.chromium.org/2100213002


Add a new kMIDS (Max Incoming Dynamic Streams) config option, to eventually
replace kMSPC.

Adds QUIC_VERSION_35 which allows endpoints to independently set max
open streams. Protected by FLAGS_quic_enable_version_35

Merge internal change: 125773608
https://codereview.chromium.org/2101353003


Flip recent QUIC flags.
https://codereview.chromium.org/2107943002/
==========

to

==========
Landing recent QUIC changes until 6/24/2016 14:00 UTC

Change QuicBufferedPacketStore to store QuicReceivedPackets instead of
QuicEncrypterPackets, since that is what the Dispatcher uses. Also to take a
const clock. Add a method for checking if packets are buffered for a connection
ID.

Also clang-format these files since they appear to be incorrectly
styled.

Merge internal change: 125777729
https://codereview.chromium.org/2099313003


Stop using next_packet_sequence_number_length in QuicPacketCreator.  No
functional change.  Protected by FLAGS_quic_simple_packet_number_length.

Merge internal change: 125727775
https://codereview.chromium.org2101623003


Add QuicConnectionCloseDelegateInterface. No functional change expected. Not
protected.

Merge internal change: 125703498
https://codereview.chromium.org/2099403002


Replace QUIC's PathMtuAckListener with a non-AckListener approach. Protected by
FLAGS_quic_no_mtu_discovery_ack_listener.

Merge internal change: 125678921
https://codereview.chromium.org/2100763003


Change users of NextPacketNumberLength to GetPacketNumberLength in
QuicPacketCreatorTest when GetPacketNumberLength is equivalent or better.

Merge internal change: 125674835
https://codereview.chromium.org/2104503003


Remove two tests from QuicConnectionTest because they were duplicates of those
in QuicPacketCreatorTest.

Merge internal change: 125640116
http://crrev.com/2102713002


Deprecate FLAGS_quic_detect_memory_corrpution.

Merge internal change: 125572214
https://codereview.chromium.org/2107473002


Deprecate FLAGS_quic_disallow_multi_packet_chlo.

Merge internal change: 125572148
https://codereview.chromium.org/2102733002


Add extra logging when QuicFramer's AppendStopWaiting fails to serialize.

Merge internal change: 125563155
https://codereview.chromium.org/2102723002


Add functionality to explicitly set SNI in the QUIC test client

The QUIC test client currently sets SNI based on the request URL which
triggers the client to connect.  This is problematic for tests which
want to set the SNI to something else (in this
case: SSL compartments tests).  This change makes it possible for such
tests to explicitly override this setting.

Merge internal change: 125561343
https://codereview.chromium.org/2101003002


Deleting blank lines from argument list of HandshakeWithFakeClient

Merge internal change: 125459408
https://codereview.chromium.org/2099123003


Let QUIC respect HTTP2 Settings frame. Currently, only
SETTINGS_HEADER_TABLE_SIZE is supported. Protected by
FLAGS_quic_respect_http2_settings_frame, default true.

Merge internal change: 125448073
https://codereview.chromium.org/2102703002]


Make QuicSpdyStream::ParseHeaderStatusCode() inparam const.

No functional change.

* Use SpdyHeaderBlock::find() instead of operator[] so that |header| is
  not
  modified.
* Make |header| const (and pass by reference instead of pointer).
* Eliminate SpdyHeaderBlock copy in
  QuicSimpleServerStream::SendResponse().

Merge internal change: 125445090
https://codereview.chromium.org/2100213002


Add a new kMIDS (Max Incoming Dynamic Streams) config option, to eventually
replace kMSPC.

Adds QUIC_VERSION_35 which allows endpoints to independently set max
open streams. Protected by FLAGS_quic_enable_version_35

Merge internal change: 125773608
https://codereview.chromium.org/2101353003


Flip recent QUIC flags.
https://codereview.chromium.org/2107943002/
==========

[commit-bot: I haz the power, 2016-06-29 02:23:51]

Committed patchset #7 (id:140001)

[commit-bot: I haz the power, 2016-06-29 02:26:07]

Description was changed from

==========
Landing recent QUIC changes until 6/24/2016 14:00 UTC

Change QuicBufferedPacketStore to store QuicReceivedPackets instead of
QuicEncrypterPackets, since that is what the Dispatcher uses. Also to take a
const clock. Add a method for checking if packets are buffered for a connection
ID.

Also clang-format these files since they appear to be incorrectly
styled.

Merge internal change: 125777729
https://codereview.chromium.org/2099313003


Stop using next_packet_sequence_number_length in QuicPacketCreator.  No
functional change.  Protected by FLAGS_quic_simple_packet_number_length.

Merge internal change: 125727775
https://codereview.chromium.org2101623003


Add QuicConnectionCloseDelegateInterface. No functional change expected. Not
protected.

Merge internal change: 125703498
https://codereview.chromium.org/2099403002


Replace QUIC's PathMtuAckListener with a non-AckListener approach. Protected by
FLAGS_quic_no_mtu_discovery_ack_listener.

Merge internal change: 125678921
https://codereview.chromium.org/2100763003


Change users of NextPacketNumberLength to GetPacketNumberLength in
QuicPacketCreatorTest when GetPacketNumberLength is equivalent or better.

Merge internal change: 125674835
https://codereview.chromium.org/2104503003


Remove two tests from QuicConnectionTest because they were duplicates of those
in QuicPacketCreatorTest.

Merge internal change: 125640116
http://crrev.com/2102713002


Deprecate FLAGS_quic_detect_memory_corrpution.

Merge internal change: 125572214
https://codereview.chromium.org/2107473002


Deprecate FLAGS_quic_disallow_multi_packet_chlo.

Merge internal change: 125572148
https://codereview.chromium.org/2102733002


Add extra logging when QuicFramer's AppendStopWaiting fails to serialize.

Merge internal change: 125563155
https://codereview.chromium.org/2102723002


Add functionality to explicitly set SNI in the QUIC test client

The QUIC test client currently sets SNI based on the request URL which
triggers the client to connect.  This is problematic for tests which
want to set the SNI to something else (in this
case: SSL compartments tests).  This change makes it possible for such
tests to explicitly override this setting.

Merge internal change: 125561343
https://codereview.chromium.org/2101003002


Deleting blank lines from argument list of HandshakeWithFakeClient

Merge internal change: 125459408
https://codereview.chromium.org/2099123003


Let QUIC respect HTTP2 Settings frame. Currently, only
SETTINGS_HEADER_TABLE_SIZE is supported. Protected by
FLAGS_quic_respect_http2_settings_frame, default true.

Merge internal change: 125448073
https://codereview.chromium.org/2102703002]


Make QuicSpdyStream::ParseHeaderStatusCode() inparam const.

No functional change.

* Use SpdyHeaderBlock::find() instead of operator[] so that |header| is
  not
  modified.
* Make |header| const (and pass by reference instead of pointer).
* Eliminate SpdyHeaderBlock copy in
  QuicSimpleServerStream::SendResponse().

Merge internal change: 125445090
https://codereview.chromium.org/2100213002


Add a new kMIDS (Max Incoming Dynamic Streams) config option, to eventually
replace kMSPC.

Adds QUIC_VERSION_35 which allows endpoints to independently set max
open streams. Protected by FLAGS_quic_enable_version_35

Merge internal change: 125773608
https://codereview.chromium.org/2101353003


Flip recent QUIC flags.
https://codereview.chromium.org/2107943002/
==========

to

==========
Landing recent QUIC changes until 6/24/2016 14:00 UTC

Change QuicBufferedPacketStore to store QuicReceivedPackets instead of
QuicEncrypterPackets, since that is what the Dispatcher uses. Also to take a
const clock. Add a method for checking if packets are buffered for a connection
ID.

Also clang-format these files since they appear to be incorrectly
styled.

Merge internal change: 125777729
https://codereview.chromium.org/2099313003

Stop using next_packet_sequence_number_length in QuicPacketCreator.  No
functional change.  Protected by FLAGS_quic_simple_packet_number_length.

Merge internal change: 125727775
https://codereview.chromium.org2101623003

Add QuicConnectionCloseDelegateInterface. No functional change expected. Not
protected.

Merge internal change: 125703498
https://codereview.chromium.org/2099403002

Replace QUIC's PathMtuAckListener with a non-AckListener approach. Protected by
FLAGS_quic_no_mtu_discovery_ack_listener.

Merge internal change: 125678921
https://codereview.chromium.org/2100763003

Change users of NextPacketNumberLength to GetPacketNumberLength in
QuicPacketCreatorTest when GetPacketNumberLength is equivalent or better.

Merge internal change: 125674835
https://codereview.chromium.org/2104503003

Remove two tests from QuicConnectionTest because they were duplicates of those
in QuicPacketCreatorTest.

Merge internal change: 125640116
http://crrev.com/2102713002

Deprecate FLAGS_quic_detect_memory_corrpution.

Merge internal change: 125572214
https://codereview.chromium.org/2107473002

Deprecate FLAGS_quic_disallow_multi_packet_chlo.

Merge internal change: 125572148
https://codereview.chromium.org/2102733002

Add extra logging when QuicFramer's AppendStopWaiting fails to serialize.

Merge internal change: 125563155
https://codereview.chromium.org/2102723002

Add functionality to explicitly set SNI in the QUIC test client

The QUIC test client currently sets SNI based on the request URL which
triggers the client to connect.  This is problematic for tests which
want to set the SNI to something else (in this
case: SSL compartments tests).  This change makes it possible for such
tests to explicitly override this setting.

Merge internal change: 125561343
https://codereview.chromium.org/2101003002

Deleting blank lines from argument list of HandshakeWithFakeClient

Merge internal change: 125459408
https://codereview.chromium.org/2099123003

Let QUIC respect HTTP2 Settings frame. Currently, only
SETTINGS_HEADER_TABLE_SIZE is supported. Protected by
FLAGS_quic_respect_http2_settings_frame, default true.

Merge internal change: 125448073
https://codereview.chromium.org/2102703002]

Make QuicSpdyStream::ParseHeaderStatusCode() inparam const.

No functional change.

* Use SpdyHeaderBlock::find() instead of operator[] so that |header| is
  not
  modified.
* Make |header| const (and pass by reference instead of pointer).
* Eliminate SpdyHeaderBlock copy in
  QuicSimpleServerStream::SendResponse().

Merge internal change: 125445090
https://codereview.chromium.org/2100213002

Add a new kMIDS (Max Incoming Dynamic Streams) config option, to eventually
replace kMSPC.

Adds QUIC_VERSION_35 which allows endpoints to independently set max
open streams. Protected by FLAGS_quic_enable_version_35

Merge internal change: 125773608
https://codereview.chromium.org/2101353003

Flip recent QUIC flags.
https://codereview.chromium.org/2107943002/

Committed: https://crrev.com/ca37822cd5ec99b6b652dec25b6a99aed1dcaa59
Cr-Commit-Position: refs/heads/master@{#402669}
==========

[commit-bot: I haz the power, 2016-06-29 02:26:09]

Patchset 7 (id:??) landed as
https://crrev.com/ca37822cd5ec99b6b652dec25b6a99aed1dcaa59
Cr-Commit-Position: refs/heads/master@{#402669}