Issue 2100213002: Make QuicSpdyStream::ParseHeaderStatusCode() inparam const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2100213002: Make QuicSpdyStream::ParseHeaderStatusCode() inparam const. (Closed)

Created:
4 years, 5 months ago by Ryan Hamilton

Modified:
4 years, 5 months ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make QuicSpdyStream::ParseHeaderStatusCode() inparam const. No functional change. * Use SpdyHeaderBlock::find() instead of operator[] so that |header| is not modified. * Make |header| const (and pass by reference instead of pointer). * Eliminate SpdyHeaderBlock copy in QuicSimpleServerStream::SendResponse(). Merge internal change: 125445090 BUG=

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -25 lines)			Patch
M	net/quic/quic_spdy_stream.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/quic/quic_spdy_stream.cc	View	3 chunks	+10 lines, -6 lines	0 comments	Download
M	net/quic/quic_spdy_stream_test.cc	View	1 chunk	+11 lines, -11 lines	0 comments	Download
M	net/tools/quic/quic_simple_server_stream.cc	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	net/tools/quic/quic_spdy_client_stream.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Dependent Patchsets:

Issue 2102703002 Patch 1

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages